Fix tests

facebook · May 31, 2023 · aa86e10 · aa86e10
1 parent f708808
commit aa86e10
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 16 deletions.
diff --git a/packages/react-reconciler/src/__tests__/ReactExpiration-test.js b/packages/react-reconciler/src/__tests__/ReactExpiration-test.js
@@ -126,21 +126,20 @@ describe('ReactExpiration', () => {
 
   it('increases priority of updates as time progresses', async () => {
     if (gate(flags => flags.forceConcurrentByDefaultForTesting)) {
-      // TODO: How does this pass on main?
-      // ReactNoop.render(<span prop="done" />);
-      // expect(ReactNoop).toMatchRenderedOutput(null);
-      //
-      // // Nothing has expired yet because time hasn't advanced.
-      // flushNextRenderIfExpired();
-      // expect(ReactNoop).toMatchRenderedOutput(null);
-      // // Advance time a bit, but not enough to expire the low pri update.
-      // ReactNoop.expire(4500);
-      // flushNextRenderIfExpired();
-      // expect(ReactNoop).toMatchRenderedOutput(null);
-      // // Advance by another second. Now the update should expire and flush.
-      // ReactNoop.expire(500);
-      // flushNextRenderIfExpired();
-      // expect(ReactNoop).toMatchRenderedOutput(<span prop="done" />);
+      ReactNoop.render(<span prop="done" />);
+      expect(ReactNoop).toMatchRenderedOutput(null);
+
+      // Nothing has expired yet because time hasn't advanced.
+      flushNextRenderIfExpired();
+      expect(ReactNoop).toMatchRenderedOutput(null);
+      // Advance time a bit, but not enough to expire the low pri update.
+      ReactNoop.expire(4500);
+      flushNextRenderIfExpired();
+      expect(ReactNoop).toMatchRenderedOutput(null);
+      // Advance by another second. Now the update should expire and flush.
+      ReactNoop.expire(500);
+      flushNextRenderIfExpired();
+      expect(ReactNoop).toMatchRenderedOutput(<span prop="done" />);
     } else {
       ReactNoop.render(<Text text="Step 1" />);
       React.startTransition(() => {

diff --git a/scripts/jest/setupTests.www.js b/scripts/jest/setupTests.www.js
@@ -9,7 +9,7 @@ jest.mock('shared/ReactFeatureFlags', () => {
   const actual = jest.requireActual('shared/forks/ReactFeatureFlags.www');
 
   // This flag is only used by tests, it should never be set elsewhere.
-  actual.forceConcurrentByDefaultForTesting = __VARIANT__;
+  actual.forceConcurrentByDefaultForTesting = !__VARIANT__;
 
   return actual;
 });