feat: DevTools - Removed useCallback.

facebook · Feb 19, 2020 · d18cf7f · d18cf7f
1 parent dc30845
commit d18cf7f
Showing 1 changed file with 56 additions and 65 deletions.
diff --git a/packages/react-devtools-shared/src/devtools/views/Components/Components.js b/packages/react-devtools-shared/src/devtools/views/Components/Components.js
@@ -111,73 +111,64 @@ function ComponentResizer({children}): {|children: Function|} {
       : RESIZE_DIRECTIONS.VERTICAL;
   }, [componentsWrapperRef]);
 
-  const onResizeStart = useCallback(() => {
-    setIsResizing(true);
-  }, [setIsResizing]);
-
-  const onResizeEnd = useCallback(() => {
-    setIsResizing(false);
-  }, [setIsResizing]);
-
-  const onResize = useCallback(
-    e => {
-      if (
-        !isResizing ||
-        componentsWrapperRef.current === null ||
-        resizeElementRef.current === null
-      ) {
-        return;
-      }
-
-      e.preventDefault();
+  const onResizeStart = () => setIsResizing(true);
+  const onResizeEnd = () => setIsResizing(false);
+  const onResize = e => {
+    if (
+      !isResizing ||
+      componentsWrapperRef.current === null ||
+      resizeElementRef.current === null
+    ) {
+      return;
+    }
 
-      const {
-        height,
-        width,
-        left,
-        top,
-      } = componentsWrapperRef.current.getBoundingClientRect();
-      const resizeDirection = getResizeDirection();
-      const currentMousePosition: number =
+    e.preventDefault();
+
+    const {
+      height,
+      width,
+      left,
+      top,
+    } = componentsWrapperRef.current.getBoundingClientRect();
+    const resizeDirection = getResizeDirection();
+    const currentMousePosition: number =
+      resizeDirection === RESIZE_DIRECTIONS.HORIZONTAL
+        ? e.clientX - left
+        : e.clientY - top;
+    const BOUNDARY_PADDING: number = 40;
+    const boundary: {|
+      min: number,
+      max: number,
+    |} = {
+      min: BOUNDARY_PADDING,
+      max:
         resizeDirection === RESIZE_DIRECTIONS.HORIZONTAL
-          ? e.clientX - left
-          : e.clientY - top;
-      const BOUNDARY_PADDING: number = 40;
-      const boundary: {|
-        min: number,
-        max: number,
-      |} = {
-        min: BOUNDARY_PADDING,
-        max:
-          resizeDirection === RESIZE_DIRECTIONS.HORIZONTAL
-            ? width - BOUNDARY_PADDING
-            : height - BOUNDARY_PADDING,
-      };
-      const isMousePositionInBounds: boolean =
-        currentMousePosition > boundary.min &&
-        currentMousePosition < boundary.max;
-
-      if (isMousePositionInBounds) {
-        const resizedElementDimension: number =
-          resizeDirection === RESIZE_DIRECTIONS.HORIZONTAL ? width : height;
-        const updatedFlexBasisValue: number =
-          (currentMousePosition / resizedElementDimension) * 100;
-
-        resizeElementRef.current.style.flexBasis = `${updatedFlexBasisValue}%`;
-
-        clearTimeout(updateLocalStorageTimeoutId.current);
-
-        updateLocalStorageTimeoutId.current = setTimeout(() => {
-          if (resizeDirection === RESIZE_DIRECTIONS.HORIZONTAL) {
-            setHorizontalPercentage(updatedFlexBasisValue);
-          } else {
-            setVerticalPercentage(updatedFlexBasisValue);
-          }
-        }, 500);
-      }
-    },
-    [componentsWrapperRef, resizeElementRef, isResizing],
-  );
+          ? width - BOUNDARY_PADDING
+          : height - BOUNDARY_PADDING,
+    };
+    const isMousePositionInBounds: boolean =
+      currentMousePosition > boundary.min &&
+      currentMousePosition < boundary.max;
+
+    if (isMousePositionInBounds) {
+      const resizedElementDimension: number =
+        resizeDirection === RESIZE_DIRECTIONS.HORIZONTAL ? width : height;
+      const updatedFlexBasisValue: number =
+        (currentMousePosition / resizedElementDimension) * 100;
+
+      resizeElementRef.current.style.flexBasis = `${updatedFlexBasisValue}%`;
+
+      clearTimeout(updateLocalStorageTimeoutId.current);
+
+      updateLocalStorageTimeoutId.current = setTimeout(() => {
+        if (resizeDirection === RESIZE_DIRECTIONS.HORIZONTAL) {
+          setHorizontalPercentage(updatedFlexBasisValue);
+        } else {
+          setVerticalPercentage(updatedFlexBasisValue);
+        }
+      }, 500);
+    }
+  };
 
   useLayoutEffect(() => {
     if (componentsWrapperRef.current !== null) {