Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture attribute only supports boolean values #11419

Closed
maxschmeling opened this issue Oct 31, 2017 · 2 comments
Closed

Capture attribute only supports boolean values #11419

maxschmeling opened this issue Oct 31, 2017 · 2 comments
Assignees
@clemmy
Labels
Component: DOM

Comments

@maxschmeling
Copy link
Contributor

This is a follow-up to #4784.

The capture attribute on input elements is currently supported, but it is configured as a HAS_BOOLEAN_VALUE attribute:

react/packages/react-dom/src/shared/HTMLDOMPropertyConfig.js

Line 33 in 1eed302

capture: HAS_BOOLEAN_VALUE,

This causes

<input type="file" capture="user" />

to render as

<input type="file" capture />

The capture attribute supports strings though: https://www.w3.org/TR/html-media-capture/#the-capture-attribute

This is very important for being able to configure the default camera selected on mobile devices.
@clemmy clemmy self-assigned this Oct 31, 2017
@maxschmeling maxschmeling mentioned this issue Nov 1, 2017
Merged
nhunzaker pushed a commit that referenced this issue Nov 12, 2017
@maxschmeling @nhunzaker
Support string values for capture attribute. (#11424)
2fe3494 
* Uses HAS_OVERLOADED_BOOLEAN_VALUE instead of HAS_BOOLEAN_VALUE
  * Allows for <input type="file" capture="user" />
Fixes #11419
@gaearon
Copy link
Collaborator

gaearon commented Nov 13, 2017

Should be out in 16.1.1.

@maxschmeling
Copy link
Contributor Author

I have confirmed that updating react-dom to 16.1.1 fixes the issue in my project. 👍

Ethan-Arrowood pushed a commit to Ethan-Arrowood/react that referenced this issue Dec 8, 2017
@maxschmeling @Ethan-Arrowood
Support string values for capture attribute. (facebook#11424)
173373e 
* Uses HAS_OVERLOADED_BOOLEAN_VALUE instead of HAS_BOOLEAN_VALUE
  * Allows for <input type="file" capture="user" />
Fixes facebook#11419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clemmy clemmy

Labels
Component: DOM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxschmeling @gaearon @clemmy