-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moar attribute tests #10509
Moar attribute tests #10509
Commits on Sep 2, 2017
-
Configuration menu - View commit details
-
Copy full SHA for ce88037 - Browse repository at this point
Copy the full SHA ce88037View commit details -
WIP Add the rest of the tests for what we expect re: unknown attributes
**what is the change?:** Adds tests for the following behavior - - Numbers and booleans should be converted to strings, and not warn - NaN, Symbols, functions, and objects should be converted to strings, and *should* warn Going to add tests for the not-warning behavior in a follow-up. These tests are not entirely passing - we either need to change what we expect or change the behavior. **why make this change?:** Gets everyone on the same page about expected behavior, and codifies it in a maintainable way **test plan:** `yarn test src/renderers/dom/shared/__tests__/ReactDOMAttribute-test.js` **issue:** facebook#10399
Configuration menu - View commit details
-
Copy full SHA for 41e3ef1 - Browse repository at this point
Copy the full SHA 41e3ef1View commit details -
WIP Add check that we *don't* warn when handling some unknown attributes
**what is the change?:** We are testing the behavior of unknown attributes, which has changed since React 15. We want to *not* warn for the following cases - - null - undefined - missing - strings - numbers - booleans **why make this change?:** We want to verify that warnings don't get fired at the wrong time. **test plan:** `yarn test src/renderers/dom/shared/__tests__/ReactDOMAttribute-test.js` **issue:** facebook#10399
Configuration menu - View commit details
-
Copy full SHA for 6b778cc - Browse repository at this point
Copy the full SHA 6b778ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 706118e - Browse repository at this point
Copy the full SHA 706118eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b94b5b7 - Browse repository at this point
Copy the full SHA b94b5b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0464fd5 - Browse repository at this point
Copy the full SHA 0464fd5View commit details -
Remove Markdown from test names
I don't think we use this convention anywhere.
Configuration menu - View commit details
-
Copy full SHA for acae10d - Browse repository at this point
Copy the full SHA acae10dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce03f1e - Browse repository at this point
Copy the full SHA ce03f1eView commit details -
Update ReactDOMAttribute test based on attribute fixture
**what is the change?:** - booleans don't get stringified - some warnings have changed since we originally wrote this **why make this change?:** The attribute behavior is finalized and now we can test it :D I also found it handy to have a row with a truly unknown attribute, so added "imaginaryFriend". **test plan:** `yarn test src/renderers/dom/shared/__tests__/ReactDOMAttribute-test.js` and comparing the tests to the attribute table **issue:** facebook#10399
Configuration menu - View commit details
-
Copy full SHA for 2fd8a5d - Browse repository at this point
Copy the full SHA 2fd8a5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b88b1d1 - Browse repository at this point
Copy the full SHA b88b1d1View commit details
Commits on Sep 5, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 083f47f - Browse repository at this point
Copy the full SHA 083f47fView commit details