Polishing up the attribute table #10543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other types are formatted as as <type: param>
acdlite
force-pushed
the
attributetablepolish
branch
from
17cb702
to
b775e74
Compare
flarnie
reviewed
Aug 25, 2017
| clearInterval(this.interval); | ||
| } | ||
| this._showInfo = true; | ||
| this.interval = setInterval(() => { |
There was a problem hiding this comment.
Nit - we could prever setTimeout to setInterval.
There was a problem hiding this comment.
Brain fart, my bad
acdlite
force-pushed
the
attributetablepolish
branch
from
93c4807
to
2d5c454
Compare
|
Not going to squash these to avoid merge conflicts due to renaming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grouping these together because they're too small for a PR on their own
<type: param>monospace: font-familyfixtures