Fix an infinite loop in new context #12402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set .return pointer inside the loop, but the top-level parent-child relationship happens outside. This ensures the top-level parent's child points to the right copy of the parent. Otherwise we may end up in a situation where (workInProgress === nextFiber) is never true and we loop forever.
gaearon
changed the title
gaearon
changed the title
acdlite
approved these changes
Mar 19, 2018
LeonYuAng3NT
pushed a commit
to LeonYuAng3NT/react
that referenced
this pull request
Mar 22, 2018
* Add a regression test for the context infinite loop * Fix the bug We set .return pointer inside the loop, but the top-level parent-child relationship happens outside. This ensures the top-level parent's child points to the right copy of the parent. Otherwise we may end up in a situation where (workInProgress === nextFiber) is never true and we loop forever.
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
* Add a regression test for the context infinite loop * Fix the bug We set .return pointer inside the loop, but the top-level parent-child relationship happens outside. This ensures the top-level parent's child points to the right copy of the parent. Otherwise we may end up in a situation where (workInProgress === nextFiber) is never true and we loop forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12389.
The issue was caused by top-level
.returnpointer not getting updated before descending. Then this condition would never be true and we'd loop forever.It doesn't affect other cases because we update
.returnin the loop. The top-level parent is just outside of the loop.