Testing builds for React/ReactDOM #17915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f39e003:
|
threepointone
force-pushed
the
testing-build
branch
from
b935ad4
to
94e396e
Compare
|
Going to figure out where the extra bytes came from and fix it, and then clean this up and open for review. |
psmolin
approved these changes
Jan 28, 2020
threepointone
force-pushed
the
testing-build
branch
2 times, most recently
from
7bfca14
to
8058e9b
Compare
threepointone
commented
Jan 28, 2020
| 'Please file an issue at https://github.com/facebook/react/issues ' + | ||
| 'if you encounter this warning.', | ||
| ); | ||
| let enqueueTaskImpl = null; |
There was a problem hiding this comment.
this had to be rewritten to prevent some unneeded code from leaking into the prod build
There was a problem hiding this comment.
Nit: Use the feature flag instead?
function enqueueTask(task: () => void) {
if (isTestingEnvironment) {
// ...
}
}There was a problem hiding this comment.
ooh, that could work.
There was a problem hiding this comment.
actually, I'll wait on this for the next PR, else I'll have to include changing all our tests to using the test build in this PR.
threepointone
force-pushed
the
testing-build
branch
3 times, most recently
from
2615a82
to
c9e0745
Compare
threepointone
commented
Jan 28, 2020
acdlite
reviewed
Jan 29, 2020
|
I think we should generally prefer feature flags to new build configurations. E.g. instead of a new build type called Then you wouldn't have to add all those special cases to change the filename. Just add a new entry to /******* React DOM Testing *******/
{
bundleTypes: [
NODE_DEV,
FB_WWW_DEV,
],
moduleType: RENDERER,
entry: 'react-dom/testing',
global: 'ReactDOM',
externals: ['react'],
},React Noop and React Test Renderer wouldn't even need a new entry because we can turn on |
threepointone
force-pushed
the
testing-build
branch
3 times, most recently
from
dcfd7c0
to
ce33146
Compare
threepointone
commented
Feb 3, 2020
acdlite
reviewed
Feb 3, 2020
acdlite
approved these changes
Feb 3, 2020
|
Bumping this just in case you didn't see it: #17915 (comment) |
|
oof, glad I caught this - the fb builds are getting overwritten by the testing builds. working on a fix. |
threepointone
force-pushed
the
testing-build
branch
2 times, most recently
from
588360a
to
0ed7da1
Compare
This PR introduces adds `react/testing` and `react-dom/testing`. - changes infra to generate these builds - exports act on ReactDOM in these testing builds - uses the new test builds in fixtures/dom In the next PR - - I'll use the new builds for all our own tests - I'll replace usages of TestUtils.act with ReactDOM.act.
threepointone
force-pushed
the
testing-build
branch
from
0ed7da1
to
f39e003
Compare
|
sizebot's being weird, so I locally made a build on master, then this branch, that resulted in this. LGTM, landing. |
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 6, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 7, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 7, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 7, 2020
Following up from facebook#17915 where we generated testing builds for `react-dom`, this PR uses those builds for our own tests. - fixes `ReactFeatureFlags.testing` to use all the default flags - changes `ReactFeatureFlags.readonly` to return `isTestEnvironment: true` (this might not strictly be needed) - with jest, mocks `react-dom` with the testing version, both for source and builds - uses `ReactDOM.act` in one of these tests to verify it actually works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces adds
react/testingandreact-dom/testing.ReactDOM.actin these testing buildsfixtures/domIn the next PR -
TestUtils.actwithReactDOM.act.