Add feature flag for removing children Map support #17990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 89c6274:
|
threepointone
approved these changes
Feb 6, 2020
Details of bundled changes.Comparing: df134d3...89c6274 react
React: size: 0.0%, gzip: 0.0% Size changes (stable) |
Update flags Update flags
trueadm
force-pushed
the
remove-map-children-support
branch
from
65ea5d3
to
89c6274
Compare
Details of bundled changes.Comparing: df134d3...89c6274 react
React: size: 0.0%, gzip: 0.0% Size changes (experimental) |
gaearon
reviewed
Feb 6, 2020
| @@ -158,14 +159,22 @@ function traverseAllChildrenImpl( | |||
| } else { | |||
| const iteratorFn = getIteratorFn(children); | |||
| if (typeof iteratorFn === 'function') { | |||
| if (__DEV__) { | |||
| if (iteratorFn === children.entries) { | |||
There was a problem hiding this comment.
After this diff, this check runs for everyone even outside of DEV. Can we move it inside the condition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a flag to disables support for Map as children (resulting in an invariant instead) and updates the existing warning.