Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cut off the tail of a SuspenseList if hydrating #18854

Merged
merged 1 commit into from
May 7, 2020

Conversation

sebmarkbage
Copy link
Collaborator

SuspenseList doesn't really support collapsed/hidden on the server atm. It doesn't make sense without streaming rendering.

If we're hydrating, we can't cut off the tail. Because if we do, then we skip hydrating those rows and as result, we leave them in the DOM forever.

This whole thing doesn't quite add up without streaming rendering.

@sebmarkbage sebmarkbage requested a review from acdlite May 7, 2020 06:43
@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels May 7, 2020
Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bb52a8:

Sandbox Source
young-cherry-v0ok5 Configuration

@sizebot
Copy link

sizebot commented May 7, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 9bb52a8

@sizebot
Copy link

sizebot commented May 7, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 9bb52a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants