-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jest to v26 along with packages related to it #19920
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8c2616d:
|
Looks like there's CI failures. Ideas? |
This one is a lint failure.
This one looks to be directly caused by one of the changed files. |
@gaearon the failure happens because fixtures was still using jest 25 in which |
@bvaughn the lint failure comes from updating eslint-plugin-jest |
@gaearon Ok it seems that fixtures/dom is still using Jest 25 even after updating the jest version in all package.json files I could find. maybe because of Anyway even after changing
This problem is probably because mocking |
scripts/jest/config.base.js
Outdated
@@ -25,5 +25,5 @@ module.exports = { | |||
testSequencer: require.resolve('./jestSequencer'), | |||
|
|||
// TODO: Upgrade to Jest 26 which uses jsdom 16 by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately that didn't fix the problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant removing the todo comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially a little skeptical about why bumping dependencies resulted in 25,000+ lines added to the yarn lockfiles.
FWIW, the jest repo's yarn.lock has increased more than 10% in the last year. it's over 680kb now. I don't think that by itself should indicate concern or a problem. Since it doesn't have a resulting bundle size impact, would timing a fully-cached 'yarn install' before and after could be enough to quell your skepticism? |
Summary
The only problem is jest-snapshot-serializer-raw, it hasn't been updated for 2 years but tests fail without it and I couldn't find a replacement.
I see only two options here:
Test Plan
run the tests, tests that passed before should not fail after the upgrade, and tests that failed before should fail too