Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduling profiler: Fix tooltip wheel event regression #22130

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Scheduling profiler: Fix tooltip wheel event regression #22130

merged 1 commit into from
Aug 18, 2021

Commits on Aug 18, 2021

  1. Scheduling profiler: Fix tooltip wheel event bug 

    Panning horizontally via mouse wheel used to allow you to scrub over snapshot images. This was accidentally broken by a recent change. The core of the fix for this was to update useSmartTooltip() to remove the depednencies array so that a newly rendered tooltip is positioned even if the mouseX/mouseY coordinates don't change (as they don't when panning via wheel).

I also cleaned a couple of unrelated things up while doing this:
* Consolodated hover reset logic formerly split between CanvasPage and Surface into the Surface handleInteraction() function.
* Cleaned up redundant ref setting code in EventTooltip.
    Brian Vaughn committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    59daebf View commit details
    Browse the repository at this point in the history