Update PropTypes for ReactElement & ReactNode #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +66,9 @@ var emptyFunction = require('emptyFunction'); | |||
|
|
|||
| var ANONYMOUS = '<<anonymous>>'; | |||
|
|
|||
| var elementTypeChecker = createElementTypeChecker(); | |||
| var nodeTypeChecker = createRenderableTypeChecker(); | |||
There was a problem hiding this comment.
Should this be renamed createNodeTypeChecker?
sebmarkbage
added
GH Review: needs-revision
and removed
GH Review: review-needed
labels
| @@ -277,10 +296,8 @@ function createShapeTypeChecker(shapeTypes) { | |||
| } | |||
|
|
|||
| function isRenderable(propValue) { | |||
There was a problem hiding this comment.
This should be renamed to isNode as well right?
There was a problem hiding this comment.
Yea, I suppose. isNode is technically a misnomer, though I guess even the {}s are technically nodes as they are defined today.
|
Everything in PropTypes are value types or union/array types. These could be called |
|
Going to leave it as is. |
zpao
force-pushed
the
proptypes-deprecation
branch
from
452ae55
to
770b579
Compare
zpao
added a commit
that referenced
this pull request
Oct 15, 2014
Update PropTypes for ReactElement & ReactNode
zpao
added a commit
that referenced
this pull request
Oct 29, 2014
This should have gone in as a part of #2343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the API to match our updated terminology, as well as bring us in line with our definition of a node. It does mean we're currently lying to people about renderables.
Reviewers: @sebmarkbage
Test Plan: npm run jest