Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DOMProperty and CSSProperty #26513

Merged
merged 7 commits into from
Mar 30, 2023
Merged

Refactor DOMProperty and CSSProperty #26513

merged 7 commits into from
Mar 30, 2023

Commits on Mar 30, 2023

  1. Move getPropertyInfo split into ReactDOMComponent

    @sebmarkbage
    sebmarkbage committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    8e50e75 View commit details
    Browse the repository at this point in the history

  2. Move isAttributeNameSafe to separate module

    @sebmarkbage
    sebmarkbage committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    e38f229 View commit details
    Browse the repository at this point in the history

  3. Move isUnitlessNumber to a separate module function

    @sebmarkbage
    sebmarkbage committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    de637ed View commit details
    Browse the repository at this point in the history

  4. Use a switch statement for isUnitlessNumber 

    This changes behavior for prefixes. I checked for which prefixes are still
returned by getComputedStyle in browsers. I also added the ones mentioned
in the original PR, whether used or not.

I removed Opera prefixes since they have since been removed in the browser
itself.

We should ideally just remove all prefixes.
    @sebmarkbage
    sebmarkbage committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    b7c3089 View commit details
    Browse the repository at this point in the history

  5. Join type checks into one switch

    @sebmarkbage
    sebmarkbage committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    7f99711 View commit details
    Browse the repository at this point in the history

  6. Inline mustUseProperty which is only used for special controlled comp… 

    …onents
    @sebmarkbage
    sebmarkbage committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    470ddc8 View commit details
    Browse the repository at this point in the history

  7. Expand ms prefix set

    @sebmarkbage
    sebmarkbage committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    6b2bc31 View commit details
    Browse the repository at this point in the history