Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Aborting with a postpone instance as a reason should postpone remaining holes #27576

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[Flight] Aborting with a postpone instance as a reason should postpone remaining holes #27576

merged 1 commit into from
Oct 24, 2023

Conversation

sebmarkbage
Copy link
Collaborator

This lets you abort with postponing semantics.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 24, 2023
@react-sizebot
Copy link

Comparing: b8e47d9...b0a569c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.04 kB 175.04 kB = 54.46 kB 54.46 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.17 kB 177.17 kB = 55.15 kB 55.15 kB
facebook-www/ReactDOM-prod.classic.js = 567.61 kB 567.61 kB = 99.94 kB 99.94 kB
facebook-www/ReactDOM-prod.modern.js = 551.47 kB 551.47 kB = 97.04 kB 97.04 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server/cjs/react-server-flight.development.js +1.59% 64.59 kB 65.61 kB +1.21% 15.65 kB 15.84 kB
oss-stable/react-server/cjs/react-server-flight.development.js +1.59% 64.59 kB 65.61 kB +1.21% 15.65 kB 15.84 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +1.04% 98.61 kB 99.64 kB +0.82% 23.40 kB 23.59 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +1.04% 98.61 kB 99.64 kB +0.82% 23.40 kB 23.59 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +1.02% 100.89 kB 101.91 kB +0.77% 24.25 kB 24.44 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +1.02% 100.89 kB 101.91 kB +0.77% 24.25 kB 24.44 kB
oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js +1.01% 106.61 kB 107.69 kB +0.74% 24.59 kB 24.77 kB
oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js +1.01% 106.61 kB 107.69 kB +0.74% 24.59 kB 24.77 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +1.01% 101.30 kB 102.32 kB +0.76% 24.37 kB 24.55 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +1.01% 101.30 kB 102.32 kB +0.76% 24.37 kB 24.55 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.99% 103.36 kB 104.39 kB +0.72% 24.93 kB 25.11 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.99% 103.36 kB 104.39 kB +0.72% 24.93 kB 25.11 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.99% 103.47 kB 104.50 kB +0.77% 24.97 kB 25.16 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.99% 103.47 kB 104.50 kB +0.77% 24.97 kB 25.16 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +0.99% 109.34 kB 110.42 kB +0.77% 25.31 kB 25.51 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +0.99% 109.34 kB 110.42 kB +0.77% 25.31 kB 25.51 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.99% 104.03 kB 105.05 kB +0.73% 24.62 kB 24.80 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.99% 104.03 kB 105.05 kB +0.73% 24.62 kB 24.80 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.96% 106.45 kB 107.48 kB +0.77% 25.23 kB 25.43 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.96% 106.45 kB 107.48 kB +0.77% 25.23 kB 25.43 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.96% 106.67 kB 107.69 kB +0.75% 25.45 kB 25.64 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.96% 106.67 kB 107.69 kB +0.75% 25.45 kB 25.64 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.94% 109.09 kB 110.11 kB +0.72% 26.12 kB 26.31 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.94% 109.09 kB 110.11 kB +0.72% 26.12 kB 26.31 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.54% 77.66 kB 78.08 kB +0.35% 18.35 kB 18.41 kB
oss-experimental/react-server/cjs/react-server-flight.production.min.js +0.39% 19.80 kB 19.88 kB +0.31% 6.86 kB 6.88 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.37% 111.91 kB 112.33 kB +0.25% 26.21 kB 26.27 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.36% 114.63 kB 115.05 kB +0.25% 27.23 kB 27.30 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.36% 115.04 kB 115.46 kB +0.26% 27.35 kB 27.42 kB
oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js +0.36% 121.09 kB 121.52 kB +0.26% 27.62 kB 27.69 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.36% 117.11 kB 117.53 kB +0.28% 27.91 kB 27.98 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.36% 117.22 kB 117.64 kB +0.24% 27.96 kB 28.03 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.36% 117.32 kB 117.74 kB +0.25% 27.42 kB 27.49 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +0.35% 123.81 kB 124.25 kB +0.25% 28.36 kB 28.43 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.35% 119.75 kB 120.17 kB +0.25% 28.06 kB 28.13 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.35% 119.96 kB 120.38 kB +0.24% 28.27 kB 28.34 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.34% 122.38 kB 122.80 kB +0.26% 28.94 kB 29.02 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +0.28% 28.49 kB 28.57 kB +0.11% 9.64 kB 9.65 kB
oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js +0.28% 29.44 kB 29.52 kB +0.15% 9.88 kB 9.90 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js +0.27% 29.27 kB 29.35 kB +0.17% 9.77 kB 9.78 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js +0.27% 29.59 kB 29.67 kB +0.14% 9.87 kB 9.88 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +0.27% 30.18 kB 30.26 kB +0.12% 10.09 kB 10.10 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +0.27% 30.02 kB 30.10 kB +0.18% 9.96 kB 9.98 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js +0.27% 30.51 kB 30.59 kB +0.18% 10.22 kB 10.23 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +0.26% 30.22 kB 30.30 kB +0.14% 10.03 kB 10.04 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js +0.26% 31.02 kB 31.10 kB +0.17% 10.37 kB 10.39 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +0.26% 31.31 kB 31.39 kB +0.17% 10.41 kB 10.43 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +0.25% 31.83 kB 31.91 kB +0.15% 10.58 kB 10.59 kB

Generated by 🚫 dangerJS against b0a569c

@sebmarkbage sebmarkbage merged commit 960ed6e into facebook:main Oct 24, 2023
36 checks passed
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 25, 2023
@gnoff
Successfully updated React from b8e47d988 to a9985529f.
3c92742 
- facebook/react#27586
- facebook/react#27577
- facebook/react#27576
@gnoff gnoff mentioned this pull request Oct 25, 2023
Merged
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 25, 2023
@gnoff
Successfully updated React from b8e47d988 to a9985529f.
e0caa47 
- facebook/react#27586
- facebook/react#27577
- facebook/react#27576
timneutkens pushed a commit to vercel/next.js that referenced this pull request Oct 25, 2023
@gnoff @kodiakhq
Update React from b8e47d988 to a9985529f. (#57442)
fcc2899 
React upstream changes:

- facebook/react#27586
- facebook/react#27577
- facebook/react#27576

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@sebmarkbage @AndyPengc12
[Flight] Aborting with a postpone instance as a reason should postpon…
1bb19a9 
…e remaining holes (facebook#27576)

This lets you abort with postponing semantics.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@sebmarkbage
[Flight] Aborting with a postpone instance as a reason should postpon…
796700a 
…e remaining holes (#27576)

This lets you abort with postponing semantics.

DiffTrain build for commit 960ed6e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff gnoff approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @gnoff @facebook-github-bot