Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:- Replaced render with createRoot method to align with react-dom verison #27722

Closed
wants to merge 1 commit into from

Conversation

Biki-das
Copy link
Contributor

Seems weird to have the fixtures file using reactDOM.render() since now we instead call createRoot method to instantiate where to render.

also gets rid of the console error

@hoxyq #27717
just to ensure this file has no weird errors in future and can test stuff easily

@react-sizebot
Copy link

Comparing: bbb9cb1...722f75c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.90 kB 175.90 kB = 54.75 kB 54.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.97 kB 177.97 kB = 55.39 kB 55.40 kB
facebook-www/ReactDOM-prod.classic.js = 569.81 kB 569.81 kB = 100.29 kB 100.29 kB
facebook-www/ReactDOM-prod.modern.js = 553.67 kB 553.67 kB = 97.38 kB 97.38 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 722f75c

@hoxyq
Copy link
Contributor

hoxyq commented Nov 22, 2023

I am not sure we actually using these fixtures, to be honest. We also probably fine with these warnings right now. Once ReactDOM.render removed, we can migrate all our local fixtures in a single commit, but I don't see the value of it right now.

@Biki-das
Copy link
Contributor Author

ok closing this then .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants