Remove JSX propTypes validation #28328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
requested review from
kassens,
sebmarkbage,
rickhanlonii and
acdlite
gaearon
force-pushed
the
rm-proptypes
branch
from
5cb2993
to
d7d3ca0
Compare
gaearon
force-pushed
the
rm-proptypes
branch
from
d7d3ca0
to
bdea370
Compare
rickhanlonii
approved these changes
Feb 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
This removes the remaining `propTypes` validation calls, making
declaring `propTypes` a no-op. In other words, React itself will no
longer validate the `propTypes` that you declare on your components.
In general, our recommendation is to use static type checking (e.g.
TypeScript). If you'd like to still run propTypes checks, you can do so
manually, same as you'd do outside React:
```js
import checkPropTypes from 'prop-types/checkPropTypes';
function Button(props) {
checkPropTypes(Button.propTypes, prop, 'prop', Button.name)
// ...
}
```
This could be automated as a Babel plugin if you want to keep these
checks implicit. (We will not be providing such a plugin, but someone in
community might be interested in building or maintaining one.)
DiffTrain build for [353ecd0](353ecd0)
huozhi
added a commit
to vercel/next.js
that referenced
this pull request
Feb 26, 2024
### React upstream changes - facebook/react#28438 - facebook/react#28436 - facebook/react#25954 - facebook/react#28434 - facebook/react#28433 - facebook/react#28432 - facebook/react#28415 - facebook/react#27903 - facebook/react#28430 - facebook/react#28424 - facebook/react#28400 - facebook/react#28422 - facebook/react#28423 - facebook/react#28412 - facebook/react#28418 - facebook/react#28421 - facebook/react#28417 - facebook/react#28399 - facebook/react#28408 - facebook/react#28350 - facebook/react#28387 - facebook/react#28403 - facebook/react#28384 - facebook/react#28409 - facebook/react#28398 - facebook/react#28405 - facebook/react#28328 - facebook/react#28402 - facebook/react#28386 - facebook/react#28388 - facebook/react#28379 - facebook/react#28383 - facebook/react#28390 - facebook/react#28389 - facebook/react#28382 - facebook/react#28348 Closes NEXT-2600
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
This removes the remaining `propTypes` validation calls, making
declaring `propTypes` a no-op. In other words, React itself will no
longer validate the `propTypes` that you declare on your components.
In general, our recommendation is to use static type checking (e.g.
TypeScript). If you'd like to still run propTypes checks, you can do so
manually, same as you'd do outside React:
```js
import checkPropTypes from 'prop-types/checkPropTypes';
function Button(props) {
checkPropTypes(Button.propTypes, prop, 'prop', Button.name)
// ...
}
```
This could be automated as a Babel plugin if you want to keep these
checks implicit. (We will not be providing such a plugin, but someone in
community might be interested in building or maintaining one.)
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
This removes the remaining `propTypes` validation calls, making
declaring `propTypes` a no-op. In other words, React itself will no
longer validate the `propTypes` that you declare on your components.
In general, our recommendation is to use static type checking (e.g.
TypeScript). If you'd like to still run propTypes checks, you can do so
manually, same as you'd do outside React:
```js
import checkPropTypes from 'prop-types/checkPropTypes';
function Button(props) {
checkPropTypes(Button.propTypes, prop, 'prop', Button.name)
// ...
}
```
This could be automated as a Babel plugin if you want to keep these
checks implicit. (We will not be providing such a plugin, but someone in
community might be interested in building or maintaining one.)
DiffTrain build for commit 353ecd0.
This was referenced Jul 22, 2024
|
Hey @gaearon I’d like to know if you have some advice for overriding Since there’s no const oldRender = React.Component.prototype.render
React.Component.prototype.render = function () {
checkPropTypes(this.constructor.propTypes, this.props, 'prop', this.constructor.name)
oldRender()
}…so I can only think of tediously adding a function to every import { checkPropTypes } from 'prop-types'
React.Component.prototype.checkTypes = function () {
checkPropTypes(this.constructor.propTypes, this.props, 'prop', this.constructor.name)
}class Foo extends React.Component {
render() {
this.checkTypes()
return null
}
}
Foo.propTypes = {
myProp: PropTypes.string
}I know you suggested using TypeScript, but TypeScript doesn’t support custom validators as PropTypes do. Also, my project uses integer props names (for performance and obfuscation) so props names are dynamic and proxied, which can’t be done with TS either. Thanks in advance |
|
I can't think of a seamless way to hack it in — your suggestion above with the manual call per render seems like the easiest way to me. If this is intolerable, then a Babel transform or an equivalent solution seems like the next thing to try. I'd expect a Babel plugin injecting this to take ~30 lines of code. |
|
I asked Claude to write a little Babel plugin that does this, here's a bit of code. module.exports = function(babel) {
const { types: t } = babel;
function isReactComponent(node) {
if (t.isIdentifier(node)) {
return node.name === 'Component' || node.name === 'PureComponent';
}
if (t.isMemberExpression(node)) {
return (
t.isIdentifier(node.object) &&
node.object.name === 'React' &&
t.isIdentifier(node.property) &&
(node.property.name === 'Component' || node.property.name === 'PureComponent')
);
}
return false;
}
return {
name: "add-prop-types-check",
visitor: {
Program: {
enter(path, state) {
state.checkPropTypesIdentifier = path.scope.generateUidIdentifier("checkPropTypes");
},
exit(path, state) {
const newImport = t.importDeclaration(
[t.importDefaultSpecifier(state.checkPropTypesIdentifier)],
t.stringLiteral("prop-types/checkPropTypes")
);
path.node.body.unshift(newImport);
}
},
ClassDeclaration(path, state) {
if (path.node.superClass && isReactComponent(path.node.superClass)) {
const renderMethod = path.node.body.body.find(
node => t.isClassMethod(node) && node.key.name === "render"
);
if (renderMethod) {
const checkPropsCall = t.expressionStatement(
t.callExpression(
state.checkPropTypesIdentifier,
[
t.memberExpression(
t.memberExpression(t.thisExpression(), t.identifier("constructor")),
t.identifier("propTypes")
),
t.memberExpression(t.thisExpression(), t.identifier("props")),
t.stringLiteral("prop"),
t.memberExpression(
t.memberExpression(t.thisExpression(), t.identifier("constructor")),
t.identifier("name")
)
]
)
);
renderMethod.body.body.unshift(checkPropsCall);
}
}
}
}
};
};Might need some tweaking but hope this helps. If you don't use Babel, you might want to port this to a different transform engine. |
|
thank you Dan! |
|
Are propType checks removed from functional components only or from class-based ones too? The RC release notes just speaks about removal from functional components: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops |
|
@matyasf Yes, in 19, @rickhanlonii The release notes say "…for functions" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the remaining
propTypesvalidation calls, making declaringpropTypesa no-op. In other words, React itself will no longer validate thepropTypesthat you declare on your components.In general, our recommendation is to use static type checking (e.g. TypeScript). If you'd like to still run propTypes checks, you can do so manually, same as you'd do outside React:
This could be automated as a Babel plugin if you want to keep these checks implicit. (We will not be providing such a plugin, but someone in community might be interested in building or maintaining one.)