Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmountComponentAtNode outside of legacy mode #28650

Merged

Conversation

rickhanlonii
Copy link
Member

No description provided.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 26, 2024
@react-sizebot
Copy link

Comparing: 56efb2e...c7a93d8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.93 kB 176.93 kB = 54.95 kB 54.95 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.33 kB 173.33 kB = 54.07 kB 54.07 kB
facebook-www/ReactDOM-prod.classic.js = 595.15 kB 595.15 kB = 104.52 kB 104.52 kB
facebook-www/ReactDOM-prod.modern.js = 578.41 kB 578.41 kB = 101.54 kB 101.54 kB
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Generated by 🚫 dangerJS against c7a93d8

@kassens
Copy link
Member

kassens commented Mar 26, 2024

Is there a way we could gate the whole ReactDOMLegacy.js file to only be included when the flag is off?

@rickhanlonii
Copy link
Member Author

Yeah but IMO there are benefits to just gating each test like greping and being able to split them out later. Like if we start to remove unmountComponentAtNode with a separate flag, it would be nice to not have to refactor this file and just change the gate on those flags.

@rickhanlonii
Copy link
Member Author

I'm... surprised the tests passed with no changes? Yolo

@rickhanlonii rickhanlonii merged commit 1a6d36b into facebook:main Mar 26, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
@rickhanlonii rickhanlonii deleted the rh/rm-unmountComponentAtNode branch March 26, 2024 20:49
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants