Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for ReactTestRenderer #28674

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Test for ReactTestRenderer #28674

merged 1 commit into from
Mar 29, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Mar 29, 2024

This is a repro for a breakage that #28672 would introduce for legacy sync rendering.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 29, 2024
@react-sizebot
Copy link

Comparing: a73c345...633df5a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.69 kB 176.69 kB = 54.93 kB 54.93 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.09 kB 173.09 kB = 53.94 kB 53.94 kB
facebook-www/ReactDOM-prod.classic.js = 592.87 kB 592.87 kB = 104.00 kB 104.00 kB
facebook-www/ReactDOM-prod.modern.js = 574.56 kB 574.56 kB = 101.02 kB 101.02 kB
test_utils/ReactAllWarnings.js Deleted 65.05 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 65.05 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Generated by 🚫 dangerJS against 633df5a

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda sucky that this is test-renderer only, we should migrate those tests

@kassens kassens merged commit 23b32d3 into facebook:main Mar 29, 2024
38 checks passed
@kassens kassens deleted the pr28674 branch March 29, 2024 18:01
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
This is a repro for a breakage that facebook#28672 would introduce for legacy
sync rendering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants