Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffolding for requestFormReset API #28808

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 10, 2024

Based on:


This sets adds a new ReactDOM export called requestFormReset, including setting up the export and creating a method on the internal ReactDOM dispatcher. It does not yet add any implementation.

Doing this in its own commit for review purposes.

The API itself will be explained in the next PR.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 10, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 10, 2024

Comparing: 41950d1...9a849fe

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.09% 168.57 kB 168.73 kB +0.09% 52.85 kB 52.89 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.09% 170.37 kB 170.53 kB +0.11% 53.37 kB 53.42 kB
facebook-www/ReactDOM-prod.classic.js +0.06% 589.82 kB 590.15 kB +0.04% 103.72 kB 103.77 kB
facebook-www/ReactDOM-prod.modern.js +0.05% 565.66 kB 565.96 kB +0.08% 99.89 kB 99.97 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.min.js +4.38% 2.72 kB 2.84 kB +6.22% 0.96 kB 1.02 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.min.js +4.38% 2.72 kB 2.84 kB +6.22% 0.96 kB 1.02 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.min.js +4.38% 2.72 kB 2.84 kB +6.22% 0.96 kB 1.02 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.js +2.73% 7.59 kB 7.80 kB +4.22% 1.68 kB 1.75 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js +2.73% 7.59 kB 7.80 kB +4.22% 1.68 kB 1.75 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.js +2.73% 7.59 kB 7.80 kB +4.22% 1.68 kB 1.75 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom.react-server.production.min.js +4.38% 2.72 kB 2.84 kB +6.22% 0.96 kB 1.02 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.min.js +4.38% 2.72 kB 2.84 kB +6.22% 0.96 kB 1.02 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.min.js +4.38% 2.72 kB 2.84 kB +6.22% 0.96 kB 1.02 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.js +2.73% 7.59 kB 7.80 kB +4.22% 1.68 kB 1.75 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js +2.73% 7.59 kB 7.80 kB +4.22% 1.68 kB 1.75 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.js +2.73% 7.59 kB 7.80 kB +4.22% 1.68 kB 1.75 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.js +1.38% 9.80 kB 9.93 kB +1.14% 2.47 kB 2.49 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.js +1.37% 9.82 kB 9.96 kB +1.24% 2.49 kB 2.52 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.js +1.37% 9.83 kB 9.96 kB +1.28% 2.49 kB 2.52 kB
oss-experimental/react-dom/cjs/react-dom.react-server.development.js +1.32% 15.63 kB 15.84 kB +1.92% 3.39 kB 3.45 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.development.js +1.32% 15.63 kB 15.84 kB +1.92% 3.39 kB 3.45 kB
oss-stable/react-dom/cjs/react-dom.react-server.development.js +1.32% 15.63 kB 15.84 kB +1.92% 3.39 kB 3.45 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +1.13% 19.42 kB 19.63 kB +1.53% 4.38 kB 4.45 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +1.13% 19.44 kB 19.66 kB +1.52% 4.41 kB 4.48 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +1.13% 19.45 kB 19.67 kB +1.52% 4.41 kB 4.48 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +1.13% 18.39 kB 18.59 kB +1.50% 4.26 kB 4.32 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +1.12% 18.41 kB 18.62 kB +1.49% 4.28 kB 4.35 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +1.12% 18.42 kB 18.62 kB +1.52% 4.28 kB 4.35 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +1.02% 3.52 kB 3.56 kB +1.12% 1.34 kB 1.36 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +1.01% 3.55 kB 3.59 kB +1.10% 1.36 kB 1.38 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +1.01% 3.56 kB 3.59 kB +1.03% 1.36 kB 1.38 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +1.01% 3.38 kB 3.41 kB +1.05% 1.24 kB 1.25 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +1.00% 3.41 kB 3.44 kB +0.95% 1.26 kB 1.28 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +1.00% 3.41 kB 3.45 kB +1.03% 1.26 kB 1.27 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Generated by 🚫 dangerJS against 9a849fe

@@ -1951,6 +1953,17 @@ function flushSyncWork() {
}
}

function requestFormReset(form: HTMLFormElement) {
previousDispatcher.r(/* requestFormReset */ form);
const formInst = getInstanceFromNodeDOMTree(form);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should only forward the call if the instance isn't owned by this renderer? the float ones arguably only need to be dispatched once in a client dispatcher but that's because there isn't really any defined ownership to tie the request to a specific dispatcher but in this case only the renderer that created the form will be able to resolve the formInst right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll make it so the default implementation throws. The reconciler implementation will look for a matching instance, then call the previous one only if none exists. That way if there's no match, you get an error.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I guess that's not so bad with error minification. it's hard to understand how you would have gotten a form to pass to this before loading a reconciler so if this ever happens you are almost certainly passing in a dom node React didn't create

Comment on lines 1962 to 1963
// TODO: What if none of the dispatchers find a matching form instance?
// Should we detect this in dev and warn?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's interesting. Feels like it should be an error but then we'd need to implement that in the isomorphic dispatcher which we probably shouldn't do. we can have it return something and if no deeper dispatcher handled it we can just call form.reset() here or we can error maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think maybe an error is the best option. It would error if you passed a non-form element into it, so that would make it consistent.

Calling form.reset immediately doesn't seem great, especially without a warning, because it's almost certainly not what you intended to happen.

@acdlite acdlite force-pushed the scaffolding-for-requestformreset branch from c632ed3 to f96f89f Compare April 10, 2024 04:05
@acdlite acdlite requested a review from gnoff April 10, 2024 16:05
@acdlite acdlite force-pushed the scaffolding-for-requestformreset branch 3 times, most recently from 7f60647 to aedda9e Compare April 10, 2024 16:18
This sets adds a new ReactDOM export called requestFormReset, including
setting up the export and creating a method on the internal ReactDOM
dispatcher. It does not yet add any implementation.

Doing this in its own commit for review purposes.

The API itself is explained in the next commit.
@acdlite acdlite force-pushed the scaffolding-for-requestformreset branch from aedda9e to 9a849fe Compare April 10, 2024 20:55
@acdlite acdlite merged commit 374b5d2 into facebook:main Apr 10, 2024
2 of 23 checks passed
acdlite added a commit that referenced this pull request Apr 10, 2024
Based on:

- #28808
- #28804 

---

This adds a React DOM method called requestFormReset that schedules a
form reset to occur when the current transition completes.

Internally, it's the same method that's called automatically whenever a
form action is submitted. It only affects uncontrolled form inputs. See
#28804 for details.

The reason for the public API is so UI libraries can implement their own
action-based APIs and maintain the form-resetting behavior, something
like this:

```js
function onSubmit(event) {
  // Disable default form submission behavior
  event.preventDefault();
  const form = event.target;
  startTransition(async () => {
    // Request the form to reset once the action
    // has completed
    requestFormReset(form);

    // Call the user-provided action prop
    await action(new FormData(form));
  })
}
```
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
Based on:

- #28804

---

This sets adds a new ReactDOM export called requestFormReset, including
setting up the export and creating a method on the internal ReactDOM
dispatcher. It does not yet add any implementation.

Doing this in its own commit for review purposes.

The API itself will be explained in the next PR.

DiffTrain build for [374b5d2](374b5d2)
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
Based on:

- #28808
- #28804

---

This adds a React DOM method called requestFormReset that schedules a
form reset to occur when the current transition completes.

Internally, it's the same method that's called automatically whenever a
form action is submitted. It only affects uncontrolled form inputs. See
#28804 for details.

The reason for the public API is so UI libraries can implement their own
action-based APIs and maintain the form-resetting behavior, something
like this:

```js
function onSubmit(event) {
  // Disable default form submission behavior
  event.preventDefault();
  const form = event.target;
  startTransition(async () => {
    // Request the form to reset once the action
    // has completed
    requestFormReset(form);

    // Call the user-provided action prop
    await action(new FormData(form));
  })
}
```

DiffTrain build for [da69b6a](da69b6a)
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Based on:

- #28804 

---

This sets adds a new ReactDOM export called requestFormReset, including
setting up the export and creating a method on the internal ReactDOM
dispatcher. It does not yet add any implementation.

Doing this in its own commit for review purposes.

The API itself will be explained in the next PR.
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Based on:

- #28808
- #28804 

---

This adds a React DOM method called requestFormReset that schedules a
form reset to occur when the current transition completes.

Internally, it's the same method that's called automatically whenever a
form action is submitted. It only affects uncontrolled form inputs. See
#28804 for details.

The reason for the public API is so UI libraries can implement their own
action-based APIs and maintain the form-resetting behavior, something
like this:

```js
function onSubmit(event) {
  // Disable default form submission behavior
  event.preventDefault();
  const form = event.target;
  startTransition(async () => {
    // Request the form to reset once the action
    // has completed
    requestFormReset(form);

    // Call the user-provided action prop
    await action(new FormData(form));
  })
}
```
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Based on:

- #28804 

---

This sets adds a new ReactDOM export called requestFormReset, including
setting up the export and creating a method on the internal ReactDOM
dispatcher. It does not yet add any implementation.

Doing this in its own commit for review purposes.

The API itself will be explained in the next PR.
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Based on:

- #28808
- #28804 

---

This adds a React DOM method called requestFormReset that schedules a
form reset to occur when the current transition completes.

Internally, it's the same method that's called automatically whenever a
form action is submitted. It only affects uncontrolled form inputs. See
#28804 for details.

The reason for the public API is so UI libraries can implement their own
action-based APIs and maintain the form-resetting behavior, something
like this:

```js
function onSubmit(event) {
  // Disable default form submission behavior
  event.preventDefault();
  const form = event.target;
  startTransition(async () => {
    // Request the form to reset once the action
    // has completed
    requestFormReset(form);

    // Call the user-provided action prop
    await action(new FormData(form));
  })
}
```
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Based on:

- facebook#28804 

---

This sets adds a new ReactDOM export called requestFormReset, including
setting up the export and creating a method on the internal ReactDOM
dispatcher. It does not yet add any implementation.

Doing this in its own commit for review purposes.

The API itself will be explained in the next PR.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Based on:

- facebook#28808
- facebook#28804 

---

This adds a React DOM method called requestFormReset that schedules a
form reset to occur when the current transition completes.

Internally, it's the same method that's called automatically whenever a
form action is submitted. It only affects uncontrolled form inputs. See
facebook#28804 for details.

The reason for the public API is so UI libraries can implement their own
action-based APIs and maintain the form-resetting behavior, something
like this:

```js
function onSubmit(event) {
  // Disable default form submission behavior
  event.preventDefault();
  const form = event.target;
  startTransition(async () => {
    // Request the form to reset once the action
    // has completed
    requestFormReset(form);

    // Call the user-provided action prop
    await action(new FormData(form));
  })
}
```
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 19, 2024
Summary:
This sync includes the changes from:
- D56103750
- [TODO] A shim for SECRET_INTERNALS

This sync includes the following changes:
- **[b5e5ce8e0](facebook/react@b5e5ce8e0 )**: Update ReactNativeTypes for root options (part 2) ([#28857](facebook/react#28857)) //<Ricky>//
- **[da6ba53b1](facebook/react@da6ba53b1 )**: [UMD] Remove umd builds ([#28735](facebook/react#28735)) //<Josh Story>//
- **[0c245df1d](facebook/react@0c245df1d )**: Complete the typo fix ([#28856](facebook/react#28856)) //<Sebastian Silbermann>//
- **[f82051d7a](facebook/react@f82051d7a )**: console test utils fix: match entire string, not just first letter ([#28855](facebook/react#28855)) //<Andrew Clark>//
- **[4ca20fd36](facebook/react@4ca20fd36 )**: Test top level fragment inside lazy semantics ([#28852](facebook/react#28852)) //<Sebastian Markbåge>//
- **[c0cf7c696](facebook/react@c0cf7c696 )**: Promote ASYNC_ITERATOR symbol to React Symbols ([#28851](facebook/react#28851)) //<Sebastian Markbåge>//
- **[657428a9e](facebook/react@657428a9e )**: Add ReactNativeTypes for root options ([#28850](facebook/react#28850)) //<Ricky>//
- **[7909d8eab](facebook/react@7909d8eab )**: [Flight] Encode ReadableStream and AsyncIterables ([#28847](facebook/react#28847)) //<Sebastian Markbåge>//
- **[13eb61d05](facebook/react@13eb61d05 )**: Move enableUseDeferredValueInitialArg to canary ([#28818](facebook/react#28818)) //<Andrew Clark>//
- **[8afa144bd](facebook/react@8afa144bd )**: Enable flag disableClientCache ([#28846](facebook/react#28846)) //<Jan Kassens>//
- **[734956ace](facebook/react@734956ace )**: Devtools: Add support for useFormStatus ([#28413](facebook/react#28413)) //<Sebastian Silbermann>//
- **[17e920c00](facebook/react@17e920c00 )**: [Flight Reply] Encode Typed Arrays and Blobs ([#28819](facebook/react#28819)) //<Sebastian Markbåge>//
- **[0347fcd00](facebook/react@0347fcd00 )**: Add on(Caught|Uncaught|Recoverable) opts to RN ([#28836](facebook/react#28836)) //<Ricky>//
- **[c113503ad](facebook/react@c113503ad )**: Flush direct streams in Bun ([#28837](facebook/react#28837)) //<Kenta Iwasaki>//
- **[9defcd56b](facebook/react@9defcd56b )**: Remove redundant props assign ([#28829](facebook/react#28829)) //<Sebastian Silbermann>//
- **[ed4023603](facebook/react@ed4023603 )**: Fix mistaken "react-server" condition ([#28835](facebook/react#28835)) //<Sebastian Markbåge>//
- **[c8a035036](facebook/react@c8a035036 )**: [Fizz] hoistables should never flush before the preamble ([#28802](facebook/react#28802)) //<Josh Story>//
- **[4f5c812a3](facebook/react@4f5c812a3 )**: DevTools: Rely on sourcemaps to compute hook name of built-in hooks in newer versions ([#28593](facebook/react#28593)) //<Sebastian Silbermann>//
- **[435415962](facebook/react@435415962 )**: Backwards compatibility for string refs on WWW ([#28826](facebook/react#28826)) //<Jack Pope>//
- **[608edcc90](facebook/react@608edcc90 )**: [tests] add `assertConsole<method>Dev` helpers ([#28732](facebook/react#28732)) //<Ricky>//
- **[da69b6af9](facebook/react@da69b6af9 )**: ReactDOM.requestFormReset  ([#28809](facebook/react#28809)) //<Andrew Clark>//
- **[374b5d26c](facebook/react@374b5d26c )**: Scaffolding for requestFormReset API ([#28808](facebook/react#28808)) //<Andrew Clark>//
- **[41950d14a](facebook/react@41950d14a )**: Automatically reset forms after action finishes ([#28804](facebook/react#28804)) //<Andrew Clark>//
- **[dc6a7e01e](facebook/react@dc6a7e01e )**: [Float] Don't preload images inside `<noscript>` ([#28815](facebook/react#28815)) //<Josh Story>//
- **[3f947b1b4](facebook/react@3f947b1b4 )**: [tests] Assert scheduler log empty in internalAct ([#28737](facebook/react#28737)) //<Ricky>//
- **[bf09089f6](facebook/react@bf09089f6 )**: Remove Scheduler.log from ReactSuspenseFuzz-test ([#28812](facebook/react#28812)) //<Ricky>//
- **[84cb3b4cb](facebook/react@84cb3b4cb )**: Hardcode disableIEWorkarounds for www ([#28811](facebook/react#28811)) //<Ricky>//
- **[2243b40ab](facebook/react@2243b40ab )**: [tests] assertLog before act in useEffectEvent ([#28763](facebook/react#28763)) //<Ricky>//
- **[dfc64c6e3](facebook/react@dfc64c6e3 )**: [tests] assertLog before act in ReactUse ([#28762](facebook/react#28762)) //<Ricky>//
- **[42eff4bc7](facebook/react@42eff4bc7 )**: [tests] Fix assertions not flushed before act ([#28745](facebook/react#28745)) //<Ricky>//
- **[ed3c65caf](facebook/react@ed3c65caf )**: Warn if outdated JSX transform is detected ([#28781](facebook/react#28781)) //<Andrew Clark>//
- **[3f9e237a2](facebook/react@3f9e237a2 )**: Fix: Suspend while recovering from hydration error ([#28800](facebook/react#28800)) //<Andrew Clark>//
- **[7f5d25e23](facebook/react@7f5d25e23 )**: Fix cloneElement using string ref w no owner ([#28797](facebook/react#28797)) //<Joseph Savona>//
- **[bf40b0244](facebook/react@bf40b0244 )**: [Fizz] Stop publishing external-runtime to stable channel ([#28796](facebook/react#28796)) //<Josh Story>//
- **[7f93cb41c](facebook/react@7f93cb41c )**: [DOM] Infer react-server entries bundles if not explicitly configured ([#28795](facebook/react#28795)) //<Josh Story>//
- **[f61316535](facebook/react@f61316535 )**: Rename SECRET INTERNALS to `__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE` ([#28789](facebook/react#28789)) //<Sebastian Markbåge>//
- **[9644d206e](facebook/react@9644d206e )**: Soften useFormState warning ([#28788](facebook/react#28788)) //<Ricky>//
- **[c771016e1](facebook/react@c771016e1 )**: Rename The Secret Export of Server Internals ([#28786](facebook/react#28786)) //<Sebastian Markbåge>//
- **[d50323eb8](facebook/react@d50323eb8 )**: Flatten ReactSharedInternals ([#28783](facebook/react#28783)) //<Sebastian Markbåge>//
- **[f62cf8c62](facebook/react@f62cf8c62 )**: [Float] treat `props.async` in Float consistent with the rest of react-dom ([#26760](facebook/react#26760)) //<Josh Story>//
- **[dfd3d5af8](facebook/react@dfd3d5af8 )**: Add support for transition{run,start,cancel} events ([#27345](facebook/react#27345)) //<Hugo Sales>//
- **[1f8327f83](facebook/react@1f8327f83 )**: [Fiber] Use real event priority for hydration scheduling ([#28765](facebook/react#28765)) //<Josh Story>//
- **[97c90ed88](facebook/react@97c90ed88 )**: [DOM] Shrink ReactDOMCurrentDispatcher method names ([#28770](facebook/react#28770)) //<Josh Story>//
- **[9007fdc8f](facebook/react@9007fdc8f )**: [DOM] Shrink ReactDOMSharedInternals source representation ([#28771](facebook/react#28771)) //<Josh Story>//
- **[14f50ad15](facebook/react@14f50ad15 )**: [Flight] Allow lazily resolving outlined models ([#28780](facebook/react#28780)) //<Sebastian Markbåge>//
- **[4c12339ce](facebook/react@4c12339ce )**: [DOM] move `flushSync` out of the reconciler ([#28500](facebook/react#28500)) //<Josh Story>//
- **[8e1462e8c](facebook/react@8e1462e8c )**: [Fiber] Move updatePriority tracking to renderers ([#28751](facebook/react#28751)) //<Josh Story>//
- **[0b3b8a6a3](facebook/react@0b3b8a6a3 )**: jsx: Remove unnecessary hasOwnProperty check ([#28775](facebook/react#28775)) //<Andrew Clark>//
- **[2acfb7b60](facebook/react@2acfb7b60 )**: [Flight] Support FormData from Server to Client ([#28754](facebook/react#28754)) //<Sebastian Markbåge>//
- **[d1547defe](facebook/react@d1547defe )**: Fast JSX: Don't clone props object ([#28768](facebook/react#28768)) //<Andrew Clark>//
- **[bfd8da807](facebook/react@bfd8da807 )**: Make class prop resolution faster ([#28766](facebook/react#28766)) //<Andrew Clark>//
- **[cbb6f2b54](facebook/react@cbb6f2b54 )**: [Flight] Support Blobs from Server to Client ([#28755](facebook/react#28755)) //<Sebastian Markbåge>//
- **[f33a6b69c](facebook/react@f33a6b69c )**: Track Owner for Server Components in DEV ([#28753](facebook/react#28753)) //<Sebastian Markbåge>//
- **[e3ebcd54b](facebook/react@e3ebcd54b )**: Move string ref coercion to JSX runtime ([#28473](facebook/react#28473)) //<Andrew Clark>//
- **[fd0da3eef](facebook/react@fd0da3eef )**: Remove _owner field from JSX elements in prod if string refs are disabled ([#28739](facebook/react#28739)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions 48b4ecc...b5e5ce8

jest_e2e[run_all_tests]
bypass-github-export-checks

Reviewed By: kassens

Differential Revision: D56251607

fbshipit-source-id: e16db2fa101fc7ed1e009158c76388206beabd5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants