Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] When halting omit any reference rather than refer to a shared missing chunk #30750

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[Flight] When halting omit any reference rather than refer to a shared missing chunk #30750

merged 1 commit into from
Aug 20, 2024

Commits on Aug 20, 2024

  1. [Flight] When halting omit any reference rather than refer to a share… 

    …d missing chunk

When aborting a prerender we should leave references unfulfilled, not share a common unfullfilled reference. functionally today this doesn't matter because we don't have resuming but the semantic is that the row was not available when the abort happened and in a resume the row should fill in. But by pointing each task to a common unfulfilled chunk we lose the ability for these references to resolves to distinct values on resume.

There are edge cases though like if we're aborting while rendering and we have a model that needs to refer to some reference that we don't know the identity of
    @gnoff
    gnoff committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b723e78 View commit details
    Browse the repository at this point in the history