[compiler] Type provider infra for tests #30776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Aug 21, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
josephsavona
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: f2c7e652c3bc17741e2dd0d360dfa0db19d664a3 Pull Request resolved: #30776
facebook-github-bot
added
the
React Core Team
[ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: e5a21067f93c34f7082622992675b371c078afe3 Pull Request resolved: #30776
[ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: d20606156784ed014170538d12388500f844320e Pull Request resolved: #30776
josephsavona
commented
Aug 21, 2024
Comment on lines
-129
to
-133
| export const ModuleTypeResolver = z | ||
| .function() | ||
| .args(z.string()) | ||
| .returns(z.nullable(TypeSchema)); | ||
|
|
There was a problem hiding this comment.
setting .returns() causes zod to return a function that internally validates the return type when you call it. that's cool but we want to control when the validation happens so i'm switching this to a plain function annotation
Adds snap/sprout support for type providers, with declarations describing some new functions in shared-runtime. This allows us to verify that the type provider infrastructure is working. I had to make a few fixes to workaround limitations in zod, but i think the types here are mostly stable enough that we won't have too much work keeping things in sync. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: d7035a2db59b4db3c935d07aa9c10f8c7124ea0a Pull Request resolved: #30776
Adds snap/sprout support for type providers, with declarations describing some new functions in shared-runtime. This allows us to verify that the type provider infrastructure is working. I had to make a few fixes to workaround limitations in zod, but i think the types here are mostly stable enough that we won't have too much work keeping things in sync. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: 1f2e147caaab34e3ccdca10a4751c5901ae4a658 Pull Request resolved: #30776
Adds snap/sprout support for type providers, with declarations describing some new functions in shared-runtime. This allows us to verify that the type provider infrastructure is working. I had to make a few fixes to workaround limitations in zod, but i think the types here are mostly stable enough that we won't have too much work keeping things in sync. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: dc14325d877b3638979d21af2e876f4bf2aadebc Pull Request resolved: #30776
Adds snap/sprout support for type providers, with declarations describing some new functions in shared-runtime. This allows us to verify that the type provider infrastructure is working. I had to make a few fixes to workaround limitations in zod, but i think the types here are mostly stable enough that we won't have too much work keeping things in sync. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: 5f1e140411006b39a55d8688f596e5a680aa96dc Pull Request resolved: #30776
josephsavona
commented
Aug 21, 2024
Comment on lines
+51
to
+65
| useFreeze: { | ||
| kind: 'hook', | ||
| returnType: {kind: 'type', name: 'Any'}, | ||
| }, | ||
| useFragment: { | ||
| kind: 'hook', | ||
| returnType: {kind: 'type', name: 'MixedReadonly'}, | ||
| noAlias: true, | ||
| }, | ||
| useNoAlias: { | ||
| kind: 'hook', | ||
| returnType: {kind: 'type', name: 'Any'}, | ||
| returnValueKind: ValueKindEnum.Mutable, | ||
| noAlias: true, | ||
| }, |
There was a problem hiding this comment.
moved from customHooks, which we can soon deprecate since it's already a no-op (we never look up information from it)
Adds snap/sprout support for type providers, with declarations describing some new functions in shared-runtime. This allows us to verify that the type provider infrastructure is working. I had to make a few fixes to workaround limitations in zod, but i think the types here are mostly stable enough that we won't have too much work keeping things in sync. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: 012cb6f5b9d11aff59c0c353a607241599a0d21a Pull Request resolved: #30776
Adds snap/sprout support for type providers, with declarations describing some new functions in shared-runtime. This allows us to verify that the type provider infrastructure is working. I had to make a few fixes to workaround limitations in zod, but i think the types here are mostly stable enough that we won't have too much work keeping things in sync. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: bfdbf67e3dd0cbfd511bed0bd6ba92266cf99ab8 Pull Request resolved: #30776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adds snap/sprout support for type providers, with declarations describing some new functions in shared-runtime. This allows us to verify that the type provider infrastructure is working. I had to make a few fixes to workaround limitations in zod, but i think the types here are mostly stable enough that we won't have too much work keeping things in sync.