Just ignore events on unmounted components #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sebmarkbage (A few people have hit this internally too.) |
sophiebits
force-pushed
the
event-unmounted
branch
from
499073a
to
1cf4720
Compare
Fixes facebook#4865 and also seems to fixes facebook#3790.
sophiebits
force-pushed
the
event-unmounted
branch
from
1cf4720
to
45f85a6
Compare
|
Are we sure this fixes it? How can we have so many events firing that aren't needed? |
|
I mean, this certainly fixes the error firing because it deletes the code that hits the error. I think most people with layers that close themselves were hitting this. |
sophiebits
added a commit
that referenced
this pull request
Sep 22, 2015
Just ignore events on unmounted components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4865 and also seems to fixes #3790.