Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing whitespace nesting warning #5099

Closed
wants to merge 3 commits into from
Closed

Fix confusing whitespace nesting warning #5099

wants to merge 3 commits into from

Conversation

loganhenson
Copy link

If any cases are missing please let me know #5071

@@ -175,7 +175,7 @@ SyntheticEvent.Interface = EventInterface;
SyntheticEvent.augmentClass = function(Class, Interface) {
var Super = this;

var E = function () {};
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint fix

@sophiebits
Copy link
Contributor

We only want to show this warning if React added the span automatically. That validation happens here:

Also, it isn't necessarily whitespace (<table>hello<tbody/></table> would also make a table > span) so we shouldn't say that it is in that case.

@gaearon
Copy link
Collaborator

gaearon commented Mar 27, 2016

It appears that this was fixed by #5753 so I’m closing. Thank you for the PR!

@gaearon gaearon closed this Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants