Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aliasify everywhere instead of browserify-global-shim #7476

Merged
merged 1 commit into from
Aug 12, 2016

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Aug 12, 2016

I already had to aliasify to have better control over the requires so we might as well do it everywhere for consistency.

This probably makes it easier to rebase the rollup work too. Aliases seems to be how you solve this in that world, since you can't just swap out the expression in an ES import.

// the rest of ReactElement.
var shimSharedModulesFiberFiles = {};
for (var key in shimSharedModulesFiles) {
if (!/ReactElement/.test(key)) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored this already so this special case for Fiber is no longer needed.

@zpao

I already had to aliasify to have better control over the requires
so we might as well do it everywhere for consistency.

This probably makes it easier to rebase the rollup work too
because aliases seems to be how you solve this in that world.
@zpao
Copy link
Member

zpao commented Aug 12, 2016

k

@sebmarkbage sebmarkbage merged commit c8f7215 into facebook:master Aug 12, 2016
@zpao zpao modified the milestone: 15-next Sep 8, 2016
@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
zpao pushed a commit that referenced this pull request Oct 4, 2016
I already had to aliasify to have better control over the requires
so we might as well do it everywhere for consistency.

This probably makes it easier to rebase the rollup work too
because aliases seems to be how you solve this in that world.
(cherry picked from commit c8f7215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants