Remove YogaLayout ViewGroup #1318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D47136243 |
Summary: Pull Request resolved: facebook#1318 We deprecated this as part of the Yoga 2.0 release. The last version is still present as part of the `release-v2.0` branch, and was still published, but we are not carrying the code forward. This removes it. There are a couple followups here: 1. The top-level organization (e.g. a gradle-specific directory called `build-logic` in a multi-language repo) can and should be cleaned up. Yoga Java bindings should be condensed to the `java` folder. 2. We no longer have a sample app excersizing the bindings. We should resolve this by getting the JNI binding UTs working in OSS again. Reviewed By: cortinico Differential Revision: D47136243 fbshipit-source-id: f145b3862f0a056bade3022f07102e1dfc17d7d9
NickGerleman
force-pushed
the
export-D47136243
branch
from
37bb04a
to
ffa1c18
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47136243 |
|
This pull request has been merged in f7324fb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We deprecated this as part of the Yoga 2.0 release. The last version is still present as part of the
release-v2.0branch, and was still published, but we are not carrying the code forward. This removes it.There are a couple followups here:
build-logicin a multi-language repo) can and should be cleaned up. Yoga Java bindings should be condensed to thejavafolder.Differential Revision: D47136243