Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insets no longer apply to statically positioned nodes #1454

Closed
wants to merge 1 commit into from
Closed

Insets no longer apply to statically positioned nodes #1454

wants to merge 1 commit into from

Commits on Dec 4, 2023

  1. Insets no longer apply to statically positioned nodes (facebook#1454) 

    Summary:

X-link: facebook/react-native#41369

One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position.

Reviewed By: NickGerleman

Differential Revision: D50507808
    @facebook-github-bot
    Joe Vilches authored and facebook-github-bot committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    6691199 View commit details
    Browse the repository at this point in the history