Fix modulemap typo #1474
Closed
Fix modulemap typo #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51472493 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebook/yoga#1474 Fixes facebook/yoga#1468 We build with Swift, but don't build something consuming Yoga module, and don't use modulemap and CocoaPods. This is a gap in validation we should figure out, but in the meantime, we should fix the typo. Differential Revision: D51472493
Summary: X-link: facebook/react-native#41564 Fixes facebook#1468 We build with Swift, but don't build something consuming Yoga module, and don't use modulemap and CocoaPods. This is a gap in validation we should figure out, but in the meantime, we should fix the typo. Reviewed By: christophpurrer Differential Revision: D51472493
NickGerleman
force-pushed
the
export-D51472493
branch
from
6d78d04
to
9bfe6d9
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebook/yoga#1474 Fixes facebook/yoga#1468 We build with Swift, but don't build something consuming Yoga module, and don't use modulemap and CocoaPods. This is a gap in validation we should figure out, but in the meantime, we should fix the typo. Reviewed By: christophpurrer Differential Revision: D51472493
|
This pull request was exported from Phabricator. Differential Revision: D51472493 |
|
This pull request has been merged in a713a59. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebook/react-native#41564 X-link: facebook/yoga#1474 Fixes facebook/yoga#1468 We build with Swift, but don't build something consuming Yoga module, and don't use modulemap and CocoaPods. This is a gap in validation we should figure out, but in the meantime, we should fix the typo. Reviewed By: christophpurrer Differential Revision: D51472493 fbshipit-source-id: 60e05cc49969f51d5fc4856cf25ce2afede72f36
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 20, 2023
Summary: Pull Request resolved: #41564 X-link: facebook/yoga#1474 Fixes facebook/yoga#1468 We build with Swift, but don't build something consuming Yoga module, and don't use modulemap and CocoaPods. This is a gap in validation we should figure out, but in the meantime, we should fix the typo. Reviewed By: christophpurrer Differential Revision: D51472493 fbshipit-source-id: 60e05cc49969f51d5fc4856cf25ce2afede72f36
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41564 X-link: facebook/yoga#1474 Fixes facebook/yoga#1468 We build with Swift, but don't build something consuming Yoga module, and don't use modulemap and CocoaPods. This is a gap in validation we should figure out, but in the meantime, we should fix the typo. Reviewed By: christophpurrer Differential Revision: D51472493 fbshipit-source-id: 60e05cc49969f51d5fc4856cf25ce2afede72f36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1468
We build with Swift, but don't build something consuming Yoga module, and don't use modulemap and CocoaPods. This is a gap in validation we should figure out, but in the meantime, we should fix the typo.
Differential Revision: D51472493