Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let flex basis support content box #1713

Closed
wants to merge 5 commits into from
Closed

Let flex basis support content box #1713

wants to merge 5 commits into from

Commits on Sep 30, 2024

  1. Rename Node.h's getResolvedDimension to getDimensionLength 

    Differential Revision: D63407730
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    31b5e63 View commit details
    Browse the repository at this point in the history

  2. Clean up calls to dimension() with a hardcoded FlexDirection 

    Differential Revision: D63408245
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b7cfdf7 View commit details
    Browse the repository at this point in the history

  3. Initial impl of content box 

    Differential Revision: D63416833
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fc590b2 View commit details
    Browse the repository at this point in the history

  4. More niche box sizing tests 

    Differential Revision: D63423302
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    af8ba77 View commit details
    Browse the repository at this point in the history

  5. Let flex basis support content box 

    Summary:
The flex basis length applies to the value of `box-sizing` per the spec: https://drafts.csswg.org/css-flexbox-1/#flex-basis-property

Changelog: [Internal]

Differential Revision: D63424590
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    11a02f7 View commit details
    Browse the repository at this point in the history