Add YGConfigGetInstanceCount #497

splhack · 2017-03-29T17:56:53Z

depends on [C#] Update YogaConfig #496
For memory leak unit test
Expose the API for C#

- Bugfix: Retain managed YogaConfig to prevent releasing unmanaged YogaConfig - Use the same YogaConfig in the copy constructor - Expose Set/GetUseWebDefaults APIs - Split YogaConfig out from YogaNode.cs

- For memory leak unit test - Expose the API for C#

facebook-github-bot · 2017-03-29T18:02:10Z

@splhack has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: - depends on #496 - For memory leak unit test - Expose the API for C# Closes #497 Reviewed By: emilsjolander Differential Revision: D4796190 Pulled By: splhack fbshipit-source-id: 99e4e78e8dfb3d459cf6cd7103ab252c3748e5a6

Summary: - depends on #497 Closes #498 Reviewed By: emilsjolander Differential Revision: D4796199 Pulled By: splhack fbshipit-source-id: c63f23da11a719b36c0d49e954b29c0016cad8c7

Summary: - depends on #496 - For memory leak unit test - Expose the API for C# Closes facebook/yoga#497 Reviewed By: emilsjolander Differential Revision: D4796190 Pulled By: splhack fbshipit-source-id: 99e4e78e8dfb3d459cf6cd7103ab252c3748e5a6

Summary: - depends on facebook#496 - For memory leak unit test - Expose the API for C# Closes facebook/yoga#497 Reviewed By: emilsjolander Differential Revision: D4796190 Pulled By: splhack fbshipit-source-id: 99e4e78e8dfb3d459cf6cd7103ab252c3748e5a6

Summary: - depends on #496 - For memory leak unit test - Expose the API for C# Closes facebook/yoga#497 Reviewed By: emilsjolander Differential Revision: D4796190 Pulled By: splhack fbshipit-source-id: 99e4e78e8dfb3d459cf6cd7103ab252c3748e5a6

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: b91f3cd7525b11bcb6446a933a8c4a0bcc7a2584

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 6371a1821b56894366d75f1e8320213ca96485ee

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 27966df93d8d71dad572ffc1c400de5c11fb2d64

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 348cfc470bdd34f1eb75d39cc93fd04648121c60

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 4f963e07be3d3266b981f1b4922621fb29948e33

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: a3a7b267943e346c3e6085660f57c7ad696a1b31

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 9488ace8bfe050f310b2d2a66aaf2a0178e51f59

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 50dc3c8161d2393049e7cfe0096a2792a388cba5

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: b5d885cc8c653cc32fee19e7d04909c044680441

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 99ad271f68fccfd711f0b600e7bb1b16a58b9d63

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 26ebc0fcb26e804364695de083b7bf49164d9ba6

Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 6d6dfec415bef9d2fc37e4ac776dfe62868b4839

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: f533c242baf8d0a5b0d5a1ce1b2320062cf5c636

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: da60f5bafe667cbec8e5a2e495238b6732a702ef

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 923b29aea2eea69b6ceb4b3591703ca22d2b4081

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 2d46f91d942df0a9464d01c8f074bbaaa32587ae

Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: a3b6a5308571ac8d2332f6f55c5f5d8f1993a45b

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 54a87a600a94925a04a8831b8b117721a39398ba

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 43d9533c623f97b327a097d7c3cd407c7a162528

Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 80068755141b0c9e2bb005d336020d8783b4fb01

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 4dbcad3998ff3c8c8827c6779257a2dd616d9976

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 17ba98cc5e13253c3b743e88bd615f2363ce84f5

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 789872c29d859f8ad2acaf116ba816d640aedb59

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 10e45f9cb999451e3832697236c29e55bc04f0fa

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: d9b2d5bd4142d603b121468d2c6e366894362603

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 99b80a974218c30ff5f9e04e97f704c6efed7c78

Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: dac73b936f38071a838d2135d298706be11128bb

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: b7a196751e62b80d364dac2b3b0a7c13bb3161e8

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: b7d048b16b08cb7dd32649ae06884aecdc383543

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: f99d3cae88a807838db65552876be5abbf3c6417

Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 4e0f15068a10f95597e3421d3e7ad84d840eec94

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: b5f159dbb472cbf3dda5535462019bc237e385d5

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 293cb7e6365b9464220ce3b915dd1afcc2db26b6

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: fd31e294655ab7d37a81adf7ea6c3f8d3e87c0d6

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 72423f737c3cabf5c44a7b9793c47450da58fb44

Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 36cf4caebaba498a806c0aeea853b54f18077832

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 6fe3c541c4d653fa7198870478a9cd0617566189

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: f433288c6175b8b49177fb9113021381e4c68377

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 67394d0a5d9d187926fd26022276c0e8a961a260

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 7c51fcb3aefea0a4d8217c474477a664b7bfd78f

Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: e581d4fee6d2179ac80e83ff38592146ddc5aa03

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: bb924211b34d569bd02fb570ae1e469c0d6fe218

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 4f416d3b31bccea1870e47929bd261eaa524649a

Summary: This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 5780f3676401afabe62c47f1384ca334ac2fd012

Summary: X-link: facebook/yoga#1370 X-link: facebook/react-native#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 58537ed635ed455ff065471bdf77061a4bf826f4

Summary: X-link: facebook/yoga#1370 Pull Request resolved: #39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 58537ed635ed455ff065471bdf77061a4bf826f4

Summary: Pull Request resolved: #1370 X-link: facebook/react-native#39369 This was added in #497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 58537ed635ed455ff065471bdf77061a4bf826f4

splhack added 2 commits March 29, 2017 09:54

[C#] Update YogaConfig

8eed68e

- Bugfix: Retain managed YogaConfig to prevent releasing unmanaged YogaConfig - Use the same YogaConfig in the copy constructor - Expose Set/GetUseWebDefaults APIs - Split YogaConfig out from YogaNode.cs

Add YGConfigGetInstanceCount

a50e567

- For memory leak unit test - Expose the API for C#

facebook-github-bot added the CLA Signed label Mar 29, 2017

splhack mentioned this pull request Mar 29, 2017

[C#] Add YogaConfig unit tests #498

Closed

facebook-github-bot closed this in facebook/react-native@ecd0df0 Apr 10, 2017

NickGerleman mentioned this pull request Sep 10, 2023

Breaking: Remove YGConfigGetInstanceCount facebook/react-native#39369

Closed

NickGerleman mentioned this pull request Sep 10, 2023

Breaking: Remove YGConfigGetInstanceCount #1370

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add YGConfigGetInstanceCount #497

Add YGConfigGetInstanceCount #497

splhack commented Mar 29, 2017

facebook-github-bot commented Mar 29, 2017

Add YGConfigGetInstanceCount #497

Add YGConfigGetInstanceCount #497

Conversation

splhack commented Mar 29, 2017

facebook-github-bot commented Mar 29, 2017