Skip range check when parsing stack trace #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdmondChuiHW
commented
Aug 20, 2024
| @@ -245,13 +245,15 @@ export class Linkifier extends Common.ObjectWrapper.ObjectWrapper<EventTypes> im | |||
| return fallbackAnchor; | |||
| } | |||
|
|
|||
| // TODO(T199120793) Skipping script range check until Hermes implements script range | |||
| const skipRangeCheck = true; | |||
There was a problem hiding this comment.
We can make this an experiment if we want. imo I think it's an overkill
vzaidman
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hermes is working on implementing proper support for script ranges: T199120793. In the meantime, we'll disable the range check so symbolication can be made available.
Long term plans are being discussed here.
Test plan
Manual E2E test as described in D60598446
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.