Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RN experiement in unit tests #104

Merged

Conversation

EdmondChuiHW
Copy link

@EdmondChuiHW EdmondChuiHW commented Aug 29, 2024

Summary

Fix the existing unit test failure.

Will unblock running unit tests in this repo as a GitHub Action in #105.

Test plan

npm run build && npm run unittest
> prebuild
> gn gen out/Default

Done. Made 1158 targets from 417 files in 496ms

> build
> autoninja -C out/Default

ninja: Entering directory `out/Default'
[367/367] STAMP obj/generate_devtools_grd.stamp

> unittest
> vpython3 scripts/test/run_unittests.py --no-text-coverage

Using Chromium binary (/Users/edmondc/ws/rn-chrome-devtools-frontend__workspace/rn-chrome-devtools-frontend/third_party/chrome/chrome-mac/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing)
Running tests from /Users/edmondc/ws/rn-chrome-devtools-frontend__workspace/rn-chrome-devtools-frontend

Using karma config /Users/edmondc/ws/rn-chrome-devtools-frontend__workspace/rn-chrome-devtools-frontend/out/Default/gen/test/karma.conf.js
29 08 2024 03:27:53.036:INFO [karma-server]: Karma v6.4.0 server started at http://localhost:9876/
29 08 2024 03:27:53.038:INFO [launcher]: Launching browsers BrowserWithArgs with concurrency unlimited
29 08 2024 03:27:53.041:INFO [launcher]: Starting browser Chrome
29 08 2024 03:27:54.280:INFO [Chrome Headless 124.0.0.0 (Mac OS 10.15.7)]: Connected on socket qPkG9WxuG5SbKoLGAAAB with id 54029838
==== SKIP: ApplicationPanelSidebar/without tab target/[crbug.com/1472237] shows cookies for all frames

==== SKIP: ApplicationPanelSidebar/without tab target/[crbug.com/1472651] shows shared storages and events for origins using shared storage

==== SKIP: ApplicationPanelSidebar/with tab target/[crbug.com/1472237] shows cookies for all frames

==== SKIP: ApplicationPanelSidebar/with tab target/[crbug.com/1472651] shows shared storages and events for origins using shared storage

==== SKIP: [crbug.com/1473557]: IDBDatabaseView/renders with a title and top-level site

==== SKIP: [crbug.com/1473557]: IDBDatabaseView/renders with an opaque storage key

==== SKIP: [crbug.com/1473557]: IDBDatabaseView/renders with a storage bucket

==== SKIP: [crbug.com/1473557]: IDBDatabaseView/renders buttons

==== SKIP: InterestGroupStorageView/[crbug.com/1473557]: updates sidebarWidget upon receiving cellFocusedEvent when InterestGroupGetter succeeds

==== SKIP: InterestGroupStorageView/[crbug.com/1473557]: updates sidebarWidget upon receiving cellFocusedEvent when InterestGroupDetailsGetter failsupdates sidebarWidget upon receiving cellFocusedEvent when InterestGroupDetailsGetter fails

==== SKIP: InterestGroupStorageView/[crbug.com/1473557]: clears sidebarWidget upon clearEvents

==== SKIP: MismatchedPreloadingGrid/[crbug.com/1473557]: renderes no diff in URL

==== SKIP: LighthousePanel/without tab taget/[crbug.com/326214132] restores the original URL when done

==== SKIP: LighthousePanel/without tab taget/[crbug.com/326214132] waits for main taget to load before linkifying

==== SKIP: LighthousePanel/with tab taget/[crbug.com/326214132] restores the original URL when done

==== SKIP: LighthousePanel/with tab taget/[crbug.com/326214132] waits for main taget to load before linkifying

==== SKIP: JSONEditor/Display command written in editor inside input bar/[crbug.com/1484534]: should not display the command into the input bar if the command is empty string

==== SKIP: TimelineFlameChartView/[crbug.com/1492405] Shows the network track correctly

==== SKIP: Dialog/positioning/[crbug.com/1441801]: sets the max width and height correctly when the dialog's content dimensions exceed the viewport and the dialog is displayed as a modal

SUCCESS: 5050 passed (19 skipped)

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW EdmondChuiHW merged commit ae992da into facebookexperimental:main Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants