Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Memory Panel by default #108

Merged

Conversation

EdmondChuiHW
Copy link

Summary

  • Add the text "Memory" to the experiment name so it's easier to search for it
  • Ship it!

Test plan

Open the debugger in an incognito window

Before:
No memory panel and experiment is off

After
Memory panel present and experiment is on
screenshot of the experiment list showing Memory panel enabled

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@@ -173,7 +173,7 @@ export const Instance = new RNExperimentsSupport();

Instance.register({
name: RNExperimentName.JS_HEAP_PROFILER_ENABLE,
title: 'Enable Heap Profiler',
title: 'Enable Heap Profiler (Memory Panel)',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this detail ❤️

@huntie huntie merged commit 150420e into facebookexperimental:main Aug 29, 2024
3 checks passed
@EdmondChuiHW EdmondChuiHW deleted the default-enable-memory-panel branch August 29, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants