Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[ReactDevTools]: wrap sendMessage expressions in setTimeout #113

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Sep 9, 2024

Summary

See https://fburl.com/workplace/zt1bzqky for full context. This is a mitigation to make highlighting work, until the root cause is fixed.

Test plan

Before:

before.mov

After:

after.mov

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

Copy link

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mitigating this so quickly 🙏🏻

@hoxyq hoxyq merged commit e32908e into main Sep 9, 2024
3 checks passed
@hoxyq hoxyq deleted the react-devtools/use-set-timeout branch September 9, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants