Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Welcome docs links for launch #121

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Update Welcome docs links for launch #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/gni/devtools_grd_files.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ grd_files_release_sources = [
"front_end/Images/profile.svg",
"front_end/Images/react_native/learn-debugging-basics.jpg",
"front_end/Images/react_native/learn-native-debugging.jpg",
"front_end/Images/react_native/learn-react-devtools.jpg",
"front_end/Images/react_native/learn-react-native-devtools.jpg",
"front_end/Images/react_native/welcomeIcon.png",
"front_end/Images/record-start.svg",
Expand Down
1 change: 0 additions & 1 deletion config/gni/devtools_image_files.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ devtools_image_files = [
"popoverArrows.png",
"react_native/learn-debugging-basics.jpg",
"react_native/learn-native-debugging.jpg",
"react_native/learn-react-devtools.jpg",
"react_native/learn-react-native-devtools.jpg",
"react_native/welcomeIcon.png",
"toolbarResizerVertical.png",
Expand Down
Binary file removed front_end/Images/react_native/learn-react-devtools.jpg
View file
Open in desktop
Binary file not shown.
17 changes: 8 additions & 9 deletions front_end/panels/rn_welcome/RNWelcome.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ const UIStrings = {
docsDebuggingBasics: 'Debugging Basics',
/** @description "Debugging Basics" item detail */
docsDebuggingBasicsDetail: 'Overview of debugging tools in React Native',
/** @description "React DevTools" title (docs item 2 - pre-launch) */
docsReactDevTools: 'React DevTools',
/** @description "React DevTools" item detail */
docsReactDevToolsDetail: 'Debug React components with React DevTools',
/** @description "React Native DevTools" title (docs item 2) */
docsReactNativeDevTools: 'React Native DevTools',
/** @description "React Native DevTools" item detail */
docsReactDevToolsDetail: 'Explore features available in React Native DevTools',
/** @description "Native Debugging" title (docs item 3) */
docsNativeDebugging: 'Native Debugging',
/** @description "Native Debugging" item detail */
Expand Down Expand Up @@ -124,7 +124,7 @@ export class RNWelcomeImpl extends UI.Widget.VBox implements
import.meta.url,
).toString();
const docsImage2Url = new URL(
'../../Images/react_native/learn-react-devtools.jpg',
'../../Images/react_native/learn-react-native-devtools.jpg',
import.meta.url,
).toString();
const docsImage3Url = new URL(
Expand Down Expand Up @@ -176,15 +176,14 @@ export class RNWelcomeImpl extends UI.Widget.VBox implements
<p>${i18nString(UIStrings.docsDebuggingBasicsDetail)}</p>
</div>
</button>
<!-- TODO(huntie): Replace this item when React Native DevTools docs are complete -->
<button class="rn-welcome-docsfeed-item" type="button" role="link" @click=${this.#handleLinkPress.bind(this, 'https:\/\/reactnative.dev/docs/debugging/react-devtools')} title=${i18nString(UIStrings.docsReactDevTools)}>
<button class="rn-welcome-docsfeed-item" type="button" role="link" @click=${this.#handleLinkPress.bind(this, 'https:\/\/reactnative.dev/docs/react-devtools')} title=${i18nString(UIStrings.docsReactNativeDevTools)}>
<div class="rn-welcome-image" style="background-image: url('${docsImage2Url}')"></div>
<div>
<p class="devtools-link">${i18nString(UIStrings.docsReactDevTools)}</p>
<p class="devtools-link">${i18nString(UIStrings.docsReactNativeDevTools)}</p>
<p>${i18nString(UIStrings.docsReactDevToolsDetail)}</p>
</div>
</button>
<button class="rn-welcome-docsfeed-item" type="button" role="link" @click=${this.#handleLinkPress.bind(this, 'https:\/\/reactnative.dev/docs/debugging/debugging-native-code')} title=${i18nString(UIStrings.docsNativeDebugging)}>
<button class="rn-welcome-docsfeed-item" type="button" role="link" @click=${this.#handleLinkPress.bind(this, 'https:\/\/reactnative.dev/docs/debugging-native-code')} title=${i18nString(UIStrings.docsNativeDebugging)}>
<div class="rn-welcome-image" style="background-image: url('${docsImage3Url}')"></div>
<div>
<p class="devtools-link">${i18nString(UIStrings.docsNativeDebugging)}</p>
Expand Down
1 change: 1 addition & 0 deletions front_end/panels/rn_welcome/rnWelcome.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@
}

.rn-welcome-image {
flex-shrink: 0;
aspect-ratio: calc(16 / 9);
height: 64px;
margin-right: 16px;
Expand Down
Loading