Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error instance to unhandled error perf metrics #78

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

EdmondChuiHW
Copy link

Summary

Adding a new field to the error evens to capture the Error instance. We can investigate stacktraces from it.

This is possible because Errors are serialisable across postMessage/iframe. Pretty cool!

Test plan

Test E2E via D58141961

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW EdmondChuiHW merged commit 3307f31 into facebookexperimental:main Jun 5, 2024
3 checks passed
@EdmondChuiHW EdmondChuiHW deleted the error-object branch June 5, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants