Refactor model observers for window title / version label #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
Depends on #86, #87, and #88.
Actions comment feedback #87 (review) and fixes the originally highlighted bug with updating the window title when Welcome is not the first view loaded. The model observer that updates the window title is now mounted in the frontend entry point (
rn_fusebox.ts
), rather than within the Welcome panel.All changes:
ReactNativeApplicationModel
tofront_end/core/sdk/
.metadataCached
member (used by Welcome panel).RNWelcomeImpl
:reactNativeVersion
— read cached value if received already (i.e. Welcome panel was opened later).FuseboxReactNativeApplicationObserver
at root entry point.Test plan
Screen.Recording.2024-07-03.at.17.00.40.mov
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.