New raysamplers

Summary: New MultinomialRaysampler succeeds GridRaysampler bringing masking and subsampling. Correspondingly, NDCMultinomialRaysampler succeeds NDCGridRaysampler. Reviewed By: nikhilaravi, shapovalov Differential Revision: D33256897 fbshipit-source-id: cd80ec6f35b110d1d20a75c62f4e889ba8fa5d45
facebookresearch · Jan 24, 2022 · 3eb4233 · 3eb4233
1 parent 174738c
commit 3eb4233
Show file tree

Hide file tree

Showing 7 changed files with 411 additions and 60 deletions.
diff --git a/projects/nerf/nerf/implicit_function.py b/projects/nerf/nerf/implicit_function.py
@@ -7,7 +7,7 @@
 from typing import Tuple
 
 import torch
-from pytorch3d.renderer import RayBundle, ray_bundle_to_ray_points, HarmonicEmbedding
+from pytorch3d.renderer import HarmonicEmbedding, RayBundle, ray_bundle_to_ray_points
 
 from .linear_with_repeat import LinearWithRepeat
 

diff --git a/pytorch3d/renderer/__init__.py b/pytorch3d/renderer/__init__.py
@@ -32,7 +32,9 @@
     HarmonicEmbedding,
     ImplicitRenderer,
     MonteCarloRaysampler,
+    MultinomialRaysampler,
     NDCGridRaysampler,
+    NDCMultinomialRaysampler,
     RayBundle,
     VolumeRenderer,
     VolumeSampler,

diff --git a/pytorch3d/renderer/implicit/__init__.py b/pytorch3d/renderer/implicit/__init__.py
@@ -6,12 +6,19 @@
 
 from .harmonic_embedding import HarmonicEmbedding
 from .raymarching import AbsorptionOnlyRaymarcher, EmissionAbsorptionRaymarcher
-from .raysampling import GridRaysampler, MonteCarloRaysampler, NDCGridRaysampler
+from .raysampling import (
+    GridRaysampler,
+    MonteCarloRaysampler,
+    MultinomialRaysampler,
+    NDCGridRaysampler,
+    NDCMultinomialRaysampler,
+)
 from .renderer import ImplicitRenderer, VolumeRenderer, VolumeSampler
 from .utils import (
     RayBundle,
     ray_bundle_to_ray_points,
     ray_bundle_variables_to_ray_points,
 )
 
+
 __all__ = [k for k in globals().keys() if not k.startswith("_")]