Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to build after #69041 #995

Closed
tobyclh opened this issue Dec 14, 2021 · 3 comments
Closed

Fail to build after #69041 #995

tobyclh opened this issue Dec 14, 2021 · 3 comments

Comments

@tobyclh
Copy link

tobyclh commented Dec 14, 2021

If you do not know the root cause of the problem / bug, and wish someone to help you, please
post according to this template:

🐛 Bugs / Unexpected behaviors

Building pytorch3d from github master shows the following error

  /tmp/pip-req-build-efpu1n0n/pytorch3d/csrc/pulsar/pytorch/renderer.cpp:944:3: error: ‘TORCH_CHECK_ARG’ was not declared in this scope
     TORCH_CHECK_ARG(
     ^~~~~~~~~~~~~~~
  /tmp/pip-req-build-efpu1n0n/pytorch3d/csrc/pulsar/pytorch/renderer.cpp:944:3: note: suggested alternative: ‘TORCH_CHECK_MSG’
     TORCH_CHECK_ARG(
     ^~~~~~~~~~~~~~~
     TORCH_CHECK_MSG

Instructions To Reproduce the Issue:

pip install "git+https://github.com/facebookresearch/pytorch3d.git"

This seems to be introduced by a very recent commit in

#define ARGCHECK TORCH_CHECK_ARG

@tobyclh
Copy link
Author

tobyclh commented Dec 14, 2021

I can successfully compile using the previous commit d049cd2.

@bottler
Copy link
Contributor

bottler commented Dec 14, 2021

Let me fill in what has happened. This is a failure to build PyTorch3D from source at the latest commit on main, which is f8fe9a2 . That commit was roughly synchronised with a PR pytorch/pytorch#69041 in PyTorch itself. Bleeding-edge PyTorch and PyTorch3D get tested together and are fine together but the change in PyTorch3D won't work with released versions of PyTorch which PyTorch3D aims to support. I hope to make a further change to PyTorch3D to restore compatibility.

@tobyclh
Copy link
Author

tobyclh commented Dec 14, 2021

I appreciate the quick response!
Thank you!

@tobyclh tobyclh closed this as completed Dec 14, 2021
facebook-github-bot pushed a commit that referenced this issue Dec 15, 2021
Summary: Restore compatibility with old C++ after recent torch change. #995

Reviewed By: patricklabatut

Differential Revision: D33093174

fbshipit-source-id: 841202fb875d601db265e93dcf9cfa4249d02b25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants