-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail to build after #69041 #995
Comments
I can successfully compile using the previous commit d049cd2. |
Let me fill in what has happened. This is a failure to build PyTorch3D from source at the latest commit on main, which is f8fe9a2 . That commit was roughly synchronised with a PR pytorch/pytorch#69041 in PyTorch itself. Bleeding-edge PyTorch and PyTorch3D get tested together and are fine together but the change in PyTorch3D won't work with released versions of PyTorch which PyTorch3D aims to support. I hope to make a further change to PyTorch3D to restore compatibility. |
I appreciate the quick response! |
Summary: Restore compatibility with old C++ after recent torch change. #995 Reviewed By: patricklabatut Differential Revision: D33093174 fbshipit-source-id: 841202fb875d601db265e93dcf9cfa4249d02b25
If you do not know the root cause of the problem / bug, and wish someone to help you, please
post according to this template:
🐛 Bugs / Unexpected behaviors
Building pytorch3d from github master shows the following error
Instructions To Reproduce the Issue:
pip install "git+https://github.com/facebookresearch/pytorch3d.git"
This seems to be introduced by a very recent commit in
pytorch3d/pytorch3d/csrc/pulsar/host/commands.h
Line 158 in f8fe9a2
The text was updated successfully, but these errors were encountered: