Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build #1689

Closed
wants to merge 1 commit into from
Closed

Fix windows build #1689

wants to merge 1 commit into from

Conversation

eclipse0922
Copy link
Contributor

@eclipse0922 eclipse0922 commented Nov 22, 2023

Change the data type usage in the code to ensure cross-platform compatibility
long -> int64_t

image

Tested under
Win 11 and Ubuntu 22.04
with
CUDA 12.1.1 torch 2.1.1

Related issues & PR

#9

#1679

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2023
@bottler
Copy link
Contributor

bottler commented Nov 22, 2023

Thank you! This is indeed correct.

@facebook-github-bot
Copy link
Contributor

@bottler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@evenking1
Copy link

WX20231205-105802
我任然没编译通过,我的环境是win10+vs2022+python3.10.11+cuda12.1+torch2.1.1

@eclipse0922
Copy link
Contributor Author

@evenking1 Thanks for the test, I will check again.

@evenking1
Copy link

@evenking1 Thanks for the test, I will check again.

"Thank you very much for getting back to me. I made some adjustments to my setup, and your method worked. The code compiled successfully. Thanks!"

@facebook-github-bot
Copy link
Contributor

@bottler merged this pull request in 7606854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants