Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ru paul documentation #2651

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

italopires
Copy link
Contributor

Summary

Once RuPaul generator is changed to Faker::TvShows::RuPaul, Faker::RuPaul is deprecated. It will remove deprecated Faker::RuPaul documentation file.

@stefannibrasil

Copy link

@gumiguelote gumiguelote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@marcelohenriq99 marcelohenriq99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @italopires I'm sure there are other files that have been moved around and the deprecated docs remained. If you find more of them, more contributions would be welcome 👍

@stefannibrasil stefannibrasil merged commit 61a5e95 into faker-ruby:main Dec 12, 2022
@stefannibrasil stefannibrasil linked an issue Dec 12, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated Faker::RuPaul documentation file
6 participants