Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitch Hedberg quotes #2721

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Mitch Hedberg quotes #2721

merged 2 commits into from
Apr 14, 2023

Conversation

MosDeef
Copy link
Contributor

@MosDeef MosDeef commented Feb 25, 2023

Summary

Added a series of quotes from late comedian Mitch Hedberg

@MosDeef MosDeef changed the title Mitch hedberg Mitch Hedberg quotes Feb 25, 2023
Copy link
Contributor

@jremes-foss jremes-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MosDeef thank you for your contribution!

What do you think of adding the locale file under a /quotes folder?

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this, thanks!

@stefannibrasil stefannibrasil merged commit 8bbdedf into faker-ruby:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants