Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix country names and codes in address #2850

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

sudeeptarlekar
Copy link
Contributor

Motivation / Background

Few countries changed their name and this PR updates those names from old ones to new ones.
Also refactored some code in address.yml file for consistency.

Resolves: #2848

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! What do you think of taking this opportunity to also format this file by running bundle exec rake reformat_yaml['lib/path/to/file.yml']?

Few countries changed their name and this PR updates those names
from old ones to new ones.
Also refactored some code in address.yml file for consistency.

Resolves: faker-ruby#2848
@sudeeptarlekar
Copy link
Contributor Author

@stefannibrasil Made a requested changes, please review again....

Thanks in advance

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! 🚀

@stefannibrasil stefannibrasil merged commit 2cd4232 into faker-ruby:main Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated country names and inconsistencies in en/address.yml
2 participants