Remove tzinfo dependency #2952
Merged
Remove tzinfo dependency #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faker unfortunately can't be relying on gems for validating random generated data for every generator we have. That introduces too much work for maintainers. Having one dependency for tests means opening the doors for more dependencies later on. Although we do our best to keep the library up to date, we can't keep up with all the validations to be passing. If users rely on valid Timezones for their apps, we recommend not relying on faker for that and instead ensure valid data is generated on their end.
thdaraujo
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faker unfortunately can't be relying on gems for
validating random generated data for every generator we have. That introduces too much work for maintainers.
Having one dependency for tests means opening the doors for more dependencies later on. Although we do our best to keep the library up to date, we can't keep up with all the validations to be passing.
If users rely on valid Timezones for their apps, we recommend not relying on faker for that and instead ensure valid data is generated on their end.
Related: #2927