Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed manifest creation and push. #312

Merged
merged 1 commit into from
Dec 18, 2023
Merged

chore: fixed manifest creation and push. #312

merged 1 commit into from
Dec 18, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 18, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Follows https://stackoverflow.com/questions/75521775/buildx-docker-image-claims-to-be-a-manifest-list and fixes currently broken manifest related CI.
Also, this is what is done by docker-manifest-create-action.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana added kind/bug Something isn't working dco-signoff: yes area/build Further information is requested labels Dec 18, 2023
@poiana
Copy link

poiana commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 54beb96 into master Dec 18, 2023
5 checks passed
@poiana poiana deleted the fix/manifest branch December 18, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build Further information is requested dco-signoff: yes kind/bug Something isn't working lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants