Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg/driverbuilder): fixed debian rpi and rt flavors kernel urls fetching #329

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Mar 28, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area pkg

What this PR does / why we need it:

This PR fixes support to fetch kernel headers for debian rpi and rt flavors, where the common package has the -$flavor suffix.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Example:

./_output/bin/driverkit docker --target debian --kernelrelease 4.19.0-26-rt-amd64 --kernelversion 1 --output-probe /tmp/mod.o --loglevel debug --builderimage auto:master
level=DEBUG msg="running without a configuration file"
level=DEBUG msg="running with options" output-module="" output-probe=/tmp/mod.o driverversion=master kernelrelease=4.19.0-26-rt-amd64 kernelversion=1 target=debian arch=amd64 kernelurls=[] repo-org=falcosecurity repo-name=libs
level=INFO msg="driver building, it will take a few seconds" processor=docker
level=DEBUG msg="doing a new docker build"
level=DEBUG msg="kernel header url found" url=http://security-cdn.debian.org/pool/main/l/linux/linux-headers-4.19.0-26-rt-amd64_4.19.304-1_amd64.deb
level=DEBUG msg="kernel header url found" url=http://security-cdn.debian.org/pool/main/l/linux/linux-headers-4.19.0-26-common-rt_4.19.304-1_all.deb
level=DEBUG msg="kernel header url found" url=http://mirrors.kernel.org/debian/pool/main/l/linux/linux-kbuild-4.19_4.19.249-2_amd64.deb

As you can see, proper headers are now found and the build succeeds:

level=INFO msg="eBPF probe available" path=/tmp/mod.o

Does this PR introduce a user-facing change?:

NONE

…ls fetching.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 28, 2024

On master instead:

./_output/bin/driverkit docker --target debian --kernelrelease 4.19.0-26-rt-amd64 --kernelversion 1 --output-probe /tmp/mod.o --loglevel debug --builderimage auto:master
level=DEBUG msg="running without a configuration file"
level=DEBUG msg="running with options" output-module="" output-probe=/tmp/mod.o driverversion=master kernelrelease=4.19.0-26-rt-amd64 kernelversion=1 target=debian arch=amd64 kernelurls=[] repo-org=falcosecurity repo-name=libs
level=INFO msg="driver building, it will take a few seconds" processor=docker
level=DEBUG msg="doing a new docker build"
level=ERROR msg=exiting err="kernel headers not found"

@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 28, 2024

/cc @EXONER4TED

Copy link
Contributor

@EXONER4TED EXONER4TED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@poiana
Copy link

poiana commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 712dd3a into master Mar 29, 2024
5 checks passed
@poiana poiana deleted the fix/debian_rpi_rt_support branch March 29, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants