-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(cmd,pkg): moved enum
to its own package.
#550
Conversation
88edbd2
to
7ad6474
Compare
Moreover, moved logLevel and logFormat enums under pkg/output. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
7ad6474
to
caae24a
Compare
case LogFormatColor: | ||
pterm.EnableColor() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Force enable-back pterm colors; this is useful when ToPtermFormatter
is called multiple times with different color log format.
/milestone v0.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area library
What this PR does / why we need it:
Moreover, moved logLevel and logFormat enums under pkg/output.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: