Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added authentication functionality for the private index. #636

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sh4n3e
Copy link

@sh4n3e sh4n3e commented Sep 19, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I have added authentication functionality for the private index.
When I use private index on Enterprise Github environment (Internal/Private Repository), Exsisted Version's falcoctl is not supported.

> falcoctl index add private_index https://raw.enterprise-gitpro.ttaallkk.top/org_name/repo_name/main/index.yaml https {{ base64.encode("Header_name:Authentication_token") }}

Signed-off-by: sh4n3e (Sanghyeon Lee) <sh4n3e@tossinvest.com>
@poiana
Copy link
Contributor

poiana commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sh4n3e
Once this PR has been reviewed and has the lgtm label, please assign alacuku for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from FedeDP and zuc September 19, 2024 05:31
@poiana poiana added the size/M label Sep 19, 2024
Signed-off-by: sh4n3e (Sanghyeon Lee) <sh4n3e@gmail.com>
@alacuku
Copy link
Member

alacuku commented Sep 20, 2024

Hey @sh4n3e, thanks for the PR.

Authentication when retrieving index files could be handy in some contexts, and I thank you for bringing this up. However, we need a simpler user experience when using authentication. Furthermore, we support different backends for index files, and the solution proposed in this PR is not flexible enough to support all the existing backends or future ones.

The command should expose three new flags:

-p, --password string   index password
      --password-stdin    read password from stdin
  -u, --username string   index username

Those values should be then used for the current backend if supported.

Here is the PR that added the same feature for the authentication command: #588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants