Adrienne / Refactor ModalManager components and ModalForm

[adrienne-deriv]

Changes:

Test coverage is covered:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

[adrienne-deriv]

Couldn't use a default {} to represent modals without props as eslint was preferring to use Record<string, never>:

[adrienne-deriv]

I had to cast the Modal component with the generic argument for React.ComponentType as TModalProps[TModalKeys], otherwise the Modal component would expect an interesect of all possible prop types instead of union of prop types:

[adrienne-deriv]

Map get() method returns the generic argument V from Map<K, V>, and modal_props is typed as Map<TModalKeys, TModalProps[TModalKeys]>, thus get() would return TModalProps[TModalKeys and not as TModalProps[T], thus I had to cast it as TModalProps[T]

[adrienne-deriv]

Added an extra mock prop for mocking the context state

[ameerul-deriv]

suggestion maybe it would be better to separate out all the typings here into its own type file? since theres quite a lot instantiated here

[yashim-deriv]

Suggested change

	const [active_modal, setActiveModal] = React.useState<TModalVariants | null>(null);
	const [previous_modal, setPreviousModal] = React.useState<TModalVariants | null>(null);
	const [modal, setModal] = React.useState<{ active: TModalVariants, previous: TModalVariants }>(null);

Looks better combined. You could move this to a hook and abstract out setting current and previous modals. Ideally, the user does not need to know how to set the previous modal

[yashim-deriv]

this can be moved to the hook as well

[yashim-deriv]

see above 😄

[farhan-nurzi-deriv]

isnt it redundant? You have checked stacked_modal above 😄

Suggested change

	{StackedModal && stacked_modal && (
	{StackedModal && (

[farhan-nurzi-deriv]

idk if its better, we can remove eslint comment with this

Suggested change

	if (!options) options = { should_save_form_history: false, should_hide_all_modals: false };
	const { should_save_form_history, should_hide_all_modals } = options;
	const default_options = { should_save_form_history: false, should_hide_all_modals: false };
	const { should_save_form_history, should_hide_all_modals } = options || default_options;

[ameerul-deriv]

LGTM