perf: refactor parts of StreamSearch #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Uzlopak should I separate the code changes that are attached in the description from the class refactor? |
gurgunday
changed the title
|
I will separate the changes in different PRs |
gurgunday
changed the title
|
This is a minor change, so that the bigger refactor doesn't introduce any other changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Modernize and improve this library as much possible starting with StreamSearch
Small improvements:
a4e91c5 — when we match, no need to calculate the pos again, let's just directly assign and check
c281add — unnecessary allocation
ca4602d — unnecessary subtraction