Avoid to rewrite the error

cli.js

@@ -28,30 +28,33 @@ function start (opts) {
 
   if (opts.help) {
     console.log(fs.readFileSync(path.join(__dirname, 'help.txt'), 'utf8'))
-    stop(0)
+    return module.exports.stop()
   }
 
   assert(opts._.length === 1, 'Missing the file parameter')
 
   return runFastify(opts)
 }
 
-function stop (code) {
-  process.exit(code)
+function stop (error) {
+  if (error) {
+    console.log(error)
+    process.exit(1)
+  }
+  process.exit()
 }
 
 function runFastify (opts) {
   var file = null
   try {
     file = require(path.resolve(process.cwd(), opts._[0]))
   } catch (e) {
-    console.log(`Cannot find the specified file: '${opts._[0]}'`)
-    stop(1)
+    return module.exports.stop(e)
   }
 
   if (file.length !== 3) {
-    throw new Error('Plugin function should contain 3 arguments. Refer to ' +
-                    'documentation for more information.')
+    return module.exports.stop(new Error('Plugin function should contain 3 arguments. Refer to ' +
+                    'documentation for more information.'))
   }
 
   const options = {
@@ -117,8 +120,8 @@ function cli () {
   }))
 }
 
+module.exports = { start, stop, runFastify, cli }
+
 if (require.main === module) {
   cli()
 }
-
-module.exports = { start, stop, runFastify, cli }

package.json

@@ -27,6 +27,11 @@
   "engines": {
     "node": ">= 4.0"
   },
+  "standard": {
+    "ignore": [
+      "test_data/parsing-error.js"
+    ]
+  },
   "dependencies": {
     "minimist": "^1.2.0",
     "pino-colada": "^1.4.0",

test.js

@@ -108,13 +108,74 @@ test('should start fastify at given socket path', t => {
 test('should only accept plugin functions with 3 arguments', t => {
   t.plan(1)
 
-  try {
-    cli.start({
-      port: 3000,
-      _: ['./examples/incorrect-plugin.js']
-    })
-    t.fail('Incorrect arguments')
-  } catch (e) {
-    t.pass('Incorrect arguments')
+  const oldStop = cli.stop
+  t.tearDown(() => { cli.stop = oldStop })
+  cli.stop = function (err) {
+    t.equal(err.message, 'Plugin function should contain 3 arguments. Refer to documentation for more information.')
+  }
+
+  cli.start({
+    port: 3000,
+    _: ['./test_data/incorrect-plugin.js']
+  })
+})
+
+test('should throw on file not found', t => {
+  t.plan(1)
+
+  const oldStop = cli.stop
+  t.tearDown(() => { cli.stop = oldStop })
+  cli.stop = function (err) {
+    t.ok(/Cannot find module.*not-found/.test(err.message), err.message)
+  }
+
+  cli.start({
+    port: 3000,
+    _: ['./test_data/not-found.js']
+  })
+})
+
+test('should throw on package not found', t => {
+  t.plan(1)
+
+  const oldStop = cli.stop
+  t.tearDown(() => { cli.stop = oldStop })
+  cli.stop = function (err) {
+    t.ok(/Cannot find module.*unknown-package/.test(err.message), err.message)
+  }
+
+  cli.start({
+    port: 3000,
+    _: ['./test_data/package-not-found.js']
+  })
+})
+
+test('should throw on parsing error', t => {
+  t.plan(1)
+
+  const oldStop = cli.stop
+  t.tearDown(() => { cli.stop = oldStop })
+  cli.stop = function (err) {
+    t.equal(err.constructor, SyntaxError)
+  }
+
+  cli.start({
+    port: 3000,
+    _: ['./test_data/parsing-error.js']
+  })
+})
+
+test('should exit without error on help', t => {
+  t.plan(1)
+
+  const oldStop = cli.stop
+  t.tearDown(() => { cli.stop = oldStop })
+  cli.stop = function (err) {
+    t.equal(err, undefined)
   }
+
+  cli.start({
+    port: 3000,
+    help: true
+  })
 })

test_data/package-not-found.js

@@ -0,0 +1,3 @@
+'use strict'
+
+require('unknown-package')

test_data/parsing-error.js

@@ -0,0 +1 @@
+'